Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate CI to github actions #49

Closed
michaelkirk opened this issue Aug 11, 2021 · 8 comments · Fixed by #50
Closed

migrate CI to github actions #49

michaelkirk opened this issue Aug 11, 2021 · 8 comments · Fixed by #50

Comments

@michaelkirk
Copy link
Member

Build is stalled: #48 (comment)

Screen Shot 2021-08-11 at 9 35 59 AM

It seems like maybe bors is set up OK and has appropriate access, but the build status never updates.

I think this is because this repo still relies on travis-ci.

There's too much verbage here for me to be willing to read right now: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing

But I believe the take away is that travis-ci is no longer an option for us unless we want to pay, so I'd recommend switching to github actions instead of travis, like we have for most of our other repositories.

@urschrei
Copy link
Member

Oh yeah, let's get off Travis ASAP. It should be straightforward since we don't need any exotic libraries here IIRC. I'll work on a PR tomorrow.

@urschrei
Copy link
Member

Although I seem to recall that GHA doesn't allow network access, which would be a spanner in the works of our (arguably not particularly useful can-we-interact-with-the-API tests).

@urschrei
Copy link
Member

@michaelkirk
Copy link
Member Author

michaelkirk commented Aug 11, 2021

maybe related? hyperium/hyper#1009

#48 updated hyper - maybe there is a corresponding change to make?

@elwerene - Were you able to have the tests passing locally?

@urschrei
Copy link
Member

maybe related? hyperium/hyper#1009

Ha I just updated reqwest and hyper

@urschrei
Copy link
Member

OK well I've completely confused myself now. That'll teach me to think "this will be a five minute PR". Tomorrow it is!

@elwerene
Copy link
Contributor

maybe related? hyperium/hyper#1009

#48 updated hyper - maybe there is a corresponding change to make?

@elwerene - Were you able to have the tests passing locally?

no - but not on master either :/

@lnicola
Copy link
Member

lnicola commented Aug 12, 2021

Drive-by remark: wouldn't it make sense to enable default-tls for reqwest if you need HTTPS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants