Switch to GH Actions, fix tests, update network libraries #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnicola
approved these changes
Aug 12, 2021
|
lgtm! bors r+ |
|
🔒 Permission denied Existing reviewers: click here to make michaelkirk a reviewer |
|
🤦♂️ added you @michaelkirk |
michaelkirk
reviewed
Aug 17, 2021
| @@ -2,7 +2,7 @@ | |||
| name = "geocoding" | |||
| description = "Geocoding library for Rust" | |||
| version = "0.3.1" | |||
| authors = ["Stephan Hügel <urschrei@gmail.com>", "Blake Grotewold <hello@grotewold.me>"] | |||
| authors = ["The Georust Developers <admins@georust.org>"] | |||
There was a problem hiding this comment.
I just tried to contact this address and it bounced:
<admins@georust.org>: host gmr-smtp-in.l.google.com[2607:f8b0:400d:c0f::e]
said: 550-5.1.1 The email account that you tried to reach does not exist.
Please try 550-5.1.1 double-checking the recipient's email address for
typos or 550-5.1.1 unnecessary spaces. Learn more at 550 5.1.1
https://support.google.com/mail/?p=NoSuchUser b14si109472pjg.2 - gsmtp (in
reply to RCPT TO command)
I understand why we might not want to have individual authors listed, but putting in a fake email address seems fraught.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49