-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline constants #56
Conversation
Changes: * Geodesic fields were are constants (not dependent on spheroid parameters) are now just constants. * Fixed the type of many constants (i64 -> usize) where applicable. * Remove arguments that are constants. * Remove casts that were made redunant by changing i64 -> usize. * Rewrite polyval; The new version is as close to optimal as my local This is the first patch in a series of PR aiming at improving performance of geodesic inverse calculation.
Minor changes to a few functions in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks I spotted last night while looking this over.
Aims to resolve: |
There are some nice perf wins here, thanks!
This PR entails a lot of different changes. Would you be willing to break it up a bit to be easier to review? |
I already did or I hope I did? 😅 my eventual goal was to wind up something like this. I guess I can try to subdivide this further. I am doing 2 different things in 1 PR (standardizing constants & changing Let me see if I can reduce the scope slightly |
Changes:
This is the first patch in a series of PR aiming at improving performance of geodesic inverse calculation.
CHANGES.md
if knowledge of this change could be valuable to users.