Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.md
if knowledge of this change could be valuable to users.Supersedes #57 - essentially reverting some of the clippy suggestions.
I did some profiling to see if I could account for the losses in the "inverse" case. Seemingly the biggest offender is an increase in the time spent in
atan2
. We haven't explicitly changed how we call that method, so I'm not sure what to make of it, but I'm willing to call the gains and losses a wash vsmain
, and merge this based on the readability improvements.