Avoid copying string for WKT parsing #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
commented
Jul 17, 2024
| @@ -11,7 +12,10 @@ pub struct Wkt<B: AsRef<[u8]>>(pub B); | |||
|
|
|||
| impl<B: AsRef<[u8]>> GeozeroGeometry for Wkt<B> { | |||
| fn process_geom<P: GeomProcessor>(&self, processor: &mut P) -> Result<()> { | |||
| read_wkt(&mut self.0.as_ref(), processor) | |||
| let wkt_str = std::str::from_utf8(self.0.as_ref()) | |||
There was a problem hiding this comment.
I know we've been changing the API repeatedly lately, but it would be nice here if the user could declare they already have UTF8 data. I.e. maybe WktStr<S> where S: AsRef<str> separated from Wkt<B> where B: AsRef<[u8]>
There was a problem hiding this comment.
I know we've been changing the API repeatedly lately, but it would be nice here if the user could declare they already have UTF8 data
To make sure I understand, you're proposing that, we remove the WktStr deprecation and make it generic? Sounds reasonable, just making sure I understand.
There was a problem hiding this comment.
Yes, I believe so. Just so that the buffers don't have to be checked again via std::str::from_utf8
michaelkirk
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently bytes are converted into a
Readand then collected back into a string. It would be preferable to pass[u8]orstrdirectly intowkt::Wkt::from_str