Add ability to convert 3d coordinates #176
Conversation
PaulWagener
changed the title
|
Hi @PaulWagener, thanks for the PR! As ever with 2D -> 3D, there's likely to be some discussion… At minimum, I don't think we can remove the As for Even more radically: we could adopt Rust-Geodesy's coordinate struct… |
|
As long as 3D coordinates will be supported I will be happy :) |
|
What more is needed for this feature to be added ? I'd be happy to help. |
|
I just wanted to bring up that this issue hurt me on a recent project. It would be great to see a solution to 3d transformations, or at least allowing transformation into ECEF, into the project and released. |
|
@lx-88 - does using this branch work for you? |
A new struct or a new trait? I thought the whole "bring your own struct" thing was kind of nice, so users don't have to first convert their data to an intermediate proj-crate format. Just brainstorming... if avoiding api-breakage is a concern, could we introduce the new 3d method with a default impl? trait Coord {
...
+ #[deprecated(note = "implement from_xyz instead, this method will be removed in a future release")]
fn from_xy(x: f64, y: f64, z:f64) -> Self;
// at some point we'd remove the default impl, which would be a breaking release - presumably in the same release as we remove `from_xy`
+ fn from_xyz(x: f64, y: f64, z:f64) -> Self {
+ Self::from_xy(x, y)
+ }
} |
| @@ -744,22 +765,24 @@ impl Proj { | |||
| let coords = PJ_LPZT { | |||
| lam: c_x, | |||
| phi: c_y, | |||
| z: 0.0, | |||
| z: c_z, | |||
| t: f64::INFINITY, | |||
| }; | |||
| unsafe { | |||
| proj_errno_reset(self.c_proj); | |||
| // PJ_DIRECTION_* determines a forward or inverse projection | |||
| let trans = proj_trans(self.c_proj, inv, PJ_COORD { lpzt: coords }); | |||
| // output of coordinates uses the PJ_XY struct | |||
| @@ -67,7 +67,8 @@ where | |||
| { | |||
| fn x(&self) -> T; | |||
| fn y(&self) -> T; | |||
| fn from_xy(x: T, y: T) -> Self; | |||
| fn z(&self) -> T; | |||
| fn from_xyz(x: T, y: T, z: T) -> Self; | |||
There was a problem hiding this comment.
Trait doc comments are now out of date.
Fixes #150
This PR adds the ability to convert 3d coordinates.
The
Coordtrait is changed to add a Z coordinate so at least a minor version bump is warranted with this change.