-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to configure building with TIFF support. #58
Conversation
I'm fine with it, but I think the network / grid download functionality requires libtiff – if we can't build with tiff support on M1, that's the fundamental problem. |
(Also, I'm in a writing hole until mid-next week, so I probably won't be able to do much other than talk about potential fixes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we can't build with tiff support on M1, that's the fundamental problem.
I think you're right about the fundamental problem.
I think it's still an improvement to make tiff support optional (and probably contingent on the network
feature). That potentially helps anyone not using the network feature and gives some way of building on M1.
Cargo.toml
Outdated
@@ -25,6 +25,7 @@ members = ["proj-sys"] | |||
|
|||
[features] | |||
bundled_proj = [ "proj-sys/bundled_proj" ] | |||
tiff = [ "proj-sys/tiff" ] | |||
pkg_config = [ "proj-sys/pkg_config" ] | |||
network = ["reqwest"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
network = ["reqwest"] | |
network = ["reqwest", "tiff"] |
Since the network grid requires tiff, maybe like this?
You're absolutely correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my one suggestion, LGTM!
306962b
to
0a3ef92
Compare
bors r=michaelkirk |
Build succeeded: |
\o/ |
Thoughts? Would be a breaking change since it defaults to not building with TIFF support, and it used to