Fix linker error when building proj-sys in debug mode with MSVC #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
|
Hi @geogcrs25832, thanks for this! I think this is uncontroversial (I have no expertise with MSVC, though), and gets us a step closer to stable builds on that platform. Could you add an entry to the changelog and I'll merge. |
tryBuild succeeded: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proj CMakeLists.txt contains instructions to add a
_dsuffix to the compiled library in certain situations:https://github.com/OSGeo/PROJ/blob/e3d7e18f988230973ced5163fa2581b6671c8755/src/CMakeLists.txt#L86
Proj-sys does not expect this suffix and fails to find the library. This results in build failure.
This PR adds support for the suffixed library.