specific errors and try_into for inner geo-types
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
force-pushed
the
mkirk/errors
branch
from
39d2722
to
2ca773d
Compare
2 tasks
michaelkirk
commented
Jan 30, 2021
| } | ||
| // currently only one error type in geo-types error enum, but that seems likely to change | ||
| #[allow(unreachable_patterns)] | ||
| other => Error::External(Box::new(other)), |
There was a problem hiding this comment.
I thought it was worth future-proofing, so we don't have to bump WKT's minimum version of geo-types again if we add to the error enum.
|
This is a really big ergonomic improvement; the enum is really useful, but it's been historically awkward to work with and this removes a lot of that friction 👍👍👍 |
bors bot
added a commit
to georust/geo
that referenced
this pull request
Feb 6, 2021
614: Specify the details of conversion failures in an exported error enum r=michaelkirk a=michaelkirk - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- I came across this while trying to improve ergonomics of the WKT crate, which relies on this conversion logic. (see georust/wkt#57) I *think* this is not a breaking change (see comment inline), but would appreciate confirmation. If I'm wrong, and it indeed is a breaking change, I'd prefer to hold off on merging it for now. Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
michaelkirk
force-pushed
the
mkirk/errors
branch
from
2ca773d
to
1ea19ae
Compare
|
Ok - updated now that the requisite geo-type 0.7.1 has been published. Are you OK with merging this @urschrei? |
|
Yep, lgtm! |
|
bors r=urschrei Excellent thanks! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.DRAFT: depends on georust/geo#614 being released first.
Add TryFrom for converting directly to
geo_types::Geometryenum members.Previously it was:
This introduced two new error cases, so I've also introduced
thiserrorwhich solves #49FIXES #49