Support 'POINT EMPTY' conversion to geo_types #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ support in Geometry<T> + support in deserialize_point
It seems to have been broken from earlier
lnicola
approved these changes
Mar 2, 2021
michaelkirk
reviewed
Mar 2, 2021
There was a problem hiding this comment.
Excellent! Thanks for taking this one!
I see one failing test when I run locally:
failures:
---- conversion::tests::convert_empty_point stdout ----
thread 'conversion::tests::convert_empty_point' panicked at 'assertion failed: res.is_err()', src/conversion.rs:370:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
conversion::tests::convert_empty_point
test result: FAILED. 60 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.11s
| Geometry::Point(g) => geo_types::Geometry::Point(g.try_into()?), | ||
| Geometry::Point(g) => { | ||
| // Special case as `geo::Point` can't be empty | ||
| if g.0.is_some() { |
There was a problem hiding this comment.
Very minor thing, but we should be able to write this in an infallible way, like:
if let Some(c) = g.0 {
geo_types::Geometry::Point(geo_types::Point(c.into()))
There was a problem hiding this comment.
I wanted to allow any other error handling / extensions we might add in the future here.
Good catch! I overlooked this test. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.closes #61