Easier serialization of wkt with ToWkt::wkt_string/write_wkt #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
force-pushed
the
mkirk/to-wkt-string
branch
from
a4291fc
to
b4074e0
Compare
Closed
Also renamed "to_wkt_string" to just "wkt_string", it's shorter and I don't think anything is lost.
michaelkirk
force-pushed
the
mkirk/to-wkt-string
branch
from
cc5f47a
to
17825e7
Compare
This was referenced Apr 9, 2022
|
At this point I do think that this impl goes in the right direction, but it is not (for me) the best possible scenario |
|
Ok, l'm going to call this ready for review. Please take a look anyone who's interested. |
michaelkirk
changed the title
urschrei
approved these changes
Apr 13, 2022
|
bors r=urschrei |
|
Already running a review |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Apr 26, 2022
92: impl ToWkt for inner geo_type variants, allow non-geotypes to impl ToWkt r=uschrei a=michaelkirk - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. - [x] I ran cargo fmt --- ~~Draft because it's based on #89, so please review that first.~~ **update:** merged! The user benefit here is the implementation of `ToWkt` directly on the inner geometry enums so... instead of: ``` let point: geo_types::point!(x: 1.0, y: 2.0); let geo_geometry = geo_types::Geometry::from(point); let string = geo_geometry.wkt_string(); assert_eq!("POINT(1 2)", string); ``` you can do: ``` let point: geo_types::point!(x: 1.0, y: 2.0); let string = point.wkt_string(); assert_eq!("POINT(1 2)", string); ``` I also wanted to detangle ToWkt from geo-types, so that (hypothetical) non-geo-types users could implement it. The majority of the lines changed are in [ToWkt for non-geotypes](75ab496), but it's a misleading large diff (sorry). Largely it's a cut and paste job: I cut the `geo-types` specific code from `towkt.rs` and pasted it into the new `geo_types_to_wkt.rs`. For symmetry, and to better reflect it's functionality, I renamed the `conversions` module to `geo_types_from_wkt`. Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
michaelkirk
added a commit
that referenced
this pull request
Apr 27, 2022
…ediate representation. Note that this isn't a performance change. It's about (hopefully) making the library easier to use. This is a corollary to #89, but for reading WKT, rather than writing. As we discussed there, probably there is no reason for the user to care about the Wkt struct. Note that the intermediate representation is still used (for now!), but the user is no longer required to interact with it. The road is open though for having a direct translation from Wkt text to the geo-types (or whatever) represenation (see geozero for inspiration).
michaelkirk
added a commit
that referenced
this pull request
Apr 27, 2022
…ediate representation. Note that this isn't a performance change. It's about (hopefully) making the library easier to use. This is a corollary to #89, but for reading WKT, rather than writing. As we discussed there, probably there is no reason for the user to care about the Wkt struct. Note that the intermediate representation is still used (for now!), but the user is no longer required to interact with it. The road is open though for having a direct translation from Wkt text to the geo-types (or whatever) represenation (see geozero for inspiration).
michaelkirk
added a commit
that referenced
this pull request
Apr 27, 2022
…ediate representation. Note that this isn't a performance change. It's about (hopefully) making the library easier to use. This is a corollary to #89, but for reading WKT, rather than writing. As we discussed there, probably there is no reason for the user to care about the Wkt struct. Note that the intermediate representation is still used (for now!), but the user is no longer required to interact with it. The road is open though for having a direct translation from Wkt text to the geo-types (or whatever) represenation (see geozero for inspiration).
Merged
3 tasks
michaelkirk
added a commit
that referenced
this pull request
Apr 27, 2022
…ediate representation. Note that this isn't a performance change. It's about (hopefully) making the library easier to use. This is a corollary to #89, but for reading WKT, rather than writing. As we discussed there, probably there is no reason for the user to care about the Wkt struct. Note that the intermediate representation is still used (for now!), but the user is no longer required to interact with it. The road is open though for having a direct translation from Wkt text to the geo-types (or whatever) represenation (see geozero for inspiration).
michaelkirk
added a commit
that referenced
this pull request
Apr 28, 2022
…ediate representation. Note that this isn't a performance change. It's about (hopefully) making the library easier to use. This is a corollary to #89, but for reading WKT, rather than writing. As we discussed there, probably there is no reason for the user to care about the Wkt struct. Note that the intermediate representation is still used (for now!), but the user is no longer required to interact with it. The road is open though for having a direct translation from Wkt text to the geo-types (or whatever) represenation (see geozero for inspiration).
bors bot
added a commit
that referenced
this pull request
Apr 28, 2022
95: FromWkt trait for reading WKT without exposing the user to the intermediate representation. r=urschrei a=michaelkirk - [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md). - [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. - [x] I ran cargo fmt --- Draft because it's based on #94. Please review that first. --- Note that this isn't a performance change. It's about (hopefully) making the library easier to use. This is a corollary to #89, but for reading WKT, rather than writing. As we discussed there, probably there is no reason for the user to care about the Wkt struct. Note that the intermediate representation is still used (for now!), but the user is no longer required to interact with it. The road is open though for having a direct translation from Wkt text to the geo-types (or whatever) represenation (see geozero for inspiration). --- I also added the missing GeometryCollection::from(wkt) implementation to make this work for all geo-types. Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Fixes #55 - adds an easier API to serialize a geo-type.
Depends on #86, so merge that first.Merged!partially conflicts with #88, because I'm relying on thesuperseded!ToWkttrait.