Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Moved GEOS-Chem Classic build system configuration to this repo #3

Closed
wants to merge 2 commits into from
Closed

[WIP] Moved GEOS-Chem Classic build system configuration to this repo #3

wants to merge 2 commits into from

Conversation

LiamBindle
Copy link
Contributor

@LiamBindle LiamBindle commented Jul 31, 2020 •
edited
Loading

This PR moves the old scripts to configure GEOS-Chem Classic to this repo. This does the following

  • Builds without a run directory (which was breaking quick-build and build-matrix wheen they included "install" in the build step
  • Should be identical to how the old GEOS-Chem Classic build system looked from the users perspective
  • Simplifies the build system in the GEOS-Chem repo

There's an accompanying PR for GEOS-Chem:

@LiamBindle
Moved (and slightly updated) the old script lines that configured GEO…
6c6ccda 
…S-Chem Classic to the new geos-chem-classic wrapper
@LiamBindle LiamBindle mentioned this pull request Jul 31, 2020
Closed
@LiamBindle LiamBindle changed the title Move Moved GEOS-Chem Classic build system configuration to this repo Jul 31, 2020
@LiamBindle LiamBindle changed the title Moved GEOS-Chem Classic build system configuration to this repo [WIP] Moved GEOS-Chem Classic build system configuration to this repo Jul 31, 2020
@LiamBindle
Copy link
Contributor Author

I accidentally did this on main rather than dev/13.0.0. It looks like it's easier to redo the changes rather than fix the conficts so I'm going to resubmit this PR in a little while.

@LiamBindle LiamBindle closed this Jul 31, 2020
@LiamBindle LiamBindle deleted the dev/move-classic-config-to-wrapper branch July 31, 2020 16:50
yantosca added a commit that referenced this pull request Oct 15, 2024
@yantosca
geos-chem-shared-docs update: GC input data; GCHP History guide
29b8615 
This commit informs the GCClassic superproject about the following
commits that were pushed to the geos-chem-shared-docs repository:

65b2a35 Merge "docs/update_guides_for_gchp" into "main"
7f0cfbb Merge PR #3 (Add doc/tutorial for GEOS-Chem input data on AWS)

These are documentation updates for the 14.5.0 release.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LiamBindle