Fixed error in CMake logic that attempted to build the KPP standalone for mechanisms other than fullchem and custom #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/CMakeLists.txt - Defined the KPPSA_FILE_NAME variable for all mechanisms - Call "add_executable(KPPSA_FILE_NAME ...) for all mechanisms - Added an else block to disable the KPPSA_FILE_NAME executable from being built except for fullchem & custom mechanisms - Wrapped the installation command for the KPPSA_FILE_NAME executable in an if block to ensure it is only built for fullchem & custom mechanisms. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
topic: Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This PR fixes the error described by @msulprizio in #78. We have reworked the logic in the CMakeLists.txt to disable building the KPP standalone executable for simulations other than fullchem & custom, even if the CMake commands are given separately.
Expected changes:
These commands now configure GEOS-Chem Classic correctly:
Related Github Issue