Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect longitude definition in HEMCO_sa_Grid.025x0625.rc and HEMCO_sa_Grid.05x0625.rc #229

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Jul 20, 2023

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Confirm you have reviewed the following documentation

Describe the update

This is the companion update to issue #228 by @nicholasbalasus. This fixes incorrect longitude definitions XMIN and XMAX in the HEMCO_sa_Grid.025x03125.rc and HEMCO_sa_Grid.05x0625.rc. Please see issue #228 for discussion.

Also added explanatory comments to make it clear that the XMIN, XMAX, YMIN, YMAX are edges of the grid.

# Emission grid specifications:
XMIN: -180.15625   # Westernmost longitude edge
XMAX:  179.84375   # Easternmost longitude edge
YMIN: -90.0        # Southernmost latitude edge
YMAX:  90.0        # Northernmost latititude edge
NX: 1152           # Number of longitudes in grid
NY: 721            # Number of latitudes in grid
NZ: 47             # Number of levels in grid

Expected changes

This only affects HEMCO standalone simulations using 0.25x0.3125 or 0.5x0.625 grids. For these simulations, the horizontal grid will now be correct.

Reference(s)

NA

Related Github Issue(s)

This commit applies the fixes suggested by @nicholasbalasus in
issue geoschem/hemco #228.

run/HEMCO_sa_Grid.025x03125.rc
- Change XMIN from -180.125 to -180.15625 (Western longitude edge)
- Change YMID from 179.875 to 179.84375 (Eastern longitude edge)
- Add explanatory comments

run/HEMCO_sa_Grid.05x0625.rc
- Change XMIN from -180.25 to -180.3125 (Western longitude edge)
- Change YMIN from 179.75 to 179.6875 (Eastern longitude edge)
- Add explanatory comments

run/HEMCO_sa_Grid.2x25
run/HEMCO_sa_Grid.4x5
- Add explanatory comments

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added category: Bug Something isn't working topic: HEMCO Standalone Model Pertaining to the HEMCO standalone labels Jul 20, 2023
@yantosca yantosca added this to the 3.7.1 milestone Jul 20, 2023
@yantosca yantosca requested a review from msulprizio July 20, 2023 15:57
@yantosca yantosca self-assigned this Jul 20, 2023
@yantosca yantosca changed the base branch from main to dev/3.7.1 July 20, 2023 15:58
@yantosca yantosca changed the title Bugfix/hco standalone grid definitions Fix incorrect longitude definition in HEMCO_sa_Grid.025x0625.rc and HEMCO_sa_Grid.05x0625.rc Jul 20, 2023
CHANGELOG.md
- Updated with a sentence about the fix for XMIN and XMAX values
  in HEMCO_sa_Grid.05x0625.rc and HEMCO_sa_Grid.025x0625.rc.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added no-diff-to-benchmark This update will have no impact on benchmark simulations and removed no-diff-to-benchmark This update will have no impact on benchmark simulations labels Jul 20, 2023
@yantosca
Copy link
Contributor Author

yantosca commented Jul 21, 2023

After merging on top of PR geoschem/geos-chem#1879, and HEMCO PR #227, all GEOS-Chem Classic integration tests passed, except TOMAS (which is a known issue that will be fixed later):

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #def9df2 GEOS-Chem submod update: Convert GC netCDF routines to netCDF-F90
GEOS-Chem #5d7b850b4 Merge PR #1884 (Updates for GEOS-Chem in GEOS)
HEMCO     #477c7e8 Merge PR #229 (Fix incorrect longitude definitions for HEMCO standalone)

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 63750168
==============================================================================
 
Execution tests:
------------------------------------------------------------------------------
gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS
gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem..........................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem_TOMAS15..................Execute Simulation....FAIL
gc_4x5_47L_merra2_fullchem_TOMAS40..................Execute Simulation....FAIL
gc_4x5_merra2_aerosol...............................Execute Simulation....PASS
gc_4x5_merra2_carbon................................Execute Simulation....PASS
gc_4x5_merra2_CH4...................................Execute Simulation....PASS
gc_4x5_merra2_CO2...................................Execute Simulation....PASS
gc_4x5_merra2_fullchem..............................Execute Simulation....PASS
gc_4x5_merra2_fullchem_aciduptake...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_APM..........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_benchmark....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA_SVPOA.............Execute Simulation....PASS
gc_4x5_merra2_fullchem_LuoWd........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_marinePOA....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_RRTMG........................Execute Simulation....PASS
gc_4x5_merra2_Hg....................................Execute Simulation....PASS
gc_4x5_merra2_metals................................Execute Simulation....PASS
gc_4x5_merra2_POPs_BaP..............................Execute Simulation....PASS
gc_4x5_merra2_tagCH4................................Execute Simulation....PASS
gc_4x5_merra2_tagCO.................................Execute Simulation....PASS
gc_4x5_merra2_tagO3.................................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers......................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers_LuoWd................Execute Simulation....PASS
 
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 24
Execution tests failed: 2
Execution tests not yet completed: 0

Furthermore, all integration tests were zero-diff w/r/t https://github.com/geoschem/geos-chem/pulls1879, and HEMCO PR #227

  • TOMAS (failed tests)
  • APM (parallelization error)
  • RRTMG diagnostic output (parallelization error)
Checking gc_05x0625_NA_47L_merra2_CH4
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_05x0625_NA_47L_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem_TOMAS15
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem_TOMAS40
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_aerosol
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_carbon
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_CH4
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_CO2
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_aciduptake
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_APM
   -> 2 differences found in OutputDir
      * GCC_14.2.1_r13/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/GEOSChem.Metrics.20190701_0000z.nc4 
        GCC_14.2.1_r14/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/GEOSChem.Metrics.20190701_0000z.nc4 
      * GCC_14.2.1_r13/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/GEOSChem.SpeciesConc.20190701_0000z.nc4 
        GCC_14.2.1_r14/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/GEOSChem.SpeciesConc.20190701_0000z.nc4 
   -> 1 difference found in Restarts
      * GCC_14.2.1_r13/rundirs/gc_4x5_merra2_fullchem_APM/Restarts/GEOSChem.Restart.20190701_0100z.nc4 
        GCC_14.2.1_r14/rundirs/gc_4x5_merra2_fullchem_APM/Restarts/GEOSChem.Restart.20190701_0100z.nc4 

Checking gc_4x5_merra2_fullchem_benchmark
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_complexSOA
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_complexSOA_SVPOA
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_LuoWd
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_marinePOA
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_RRTMG
   -> 1 difference found in OutputDir
      * GCC_14.2.1_r13/rundirs/gc_4x5_merra2_fullchem_RRTMG/OutputDir/GEOSChem.RRTMG.20190701_0000z.nc4 
        GCC_14.2.1_r14/rundirs/gc_4x5_merra2_fullchem_RRTMG/OutputDir/GEOSChem.RRTMG.20190701_0000z.nc4 
   -> No differences in Restarts

Checking gc_4x5_merra2_Hg
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_metals
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_POPs_BaP
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_tagCH4
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_tagCO
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_tagO3
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_TransportTracers
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_TransportTracers_LuoWd
   -> No differences in OutputDir
   -> No differences in Restarts

@yantosca
Copy link
Contributor Author

After merging on top of PR geoschem/geos-chem#1879 and PR #227, all GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCClassic #3ca40a9 GEOS-Chem submod update: Convert GC netCDF routines to netCDF-F90
GEOS-Chem #5d7b850b4 Merge PR #1884 (Updates for GEOS-Chem in GEOS)
HEMCO     #477c7e8 Merge PR #229 (Fix incorrect longitude definitions for HEMCO standalone)

Number of execution tests: 5

Submitted as SLURM job: 63752023
==============================================================================
 
Execution tests:
------------------------------------------------------------------------------
gchp_merra2_fullchem................................Execute Simulation....PASS
gchp_merra2_fullchem_benchmark......................Execute Simulation....PASS
gchp_merra2_fullchem_RRTMG..........................Execute Simulation....PASS
gchp_merra2_tagO3...................................Execute Simulation....PASS
gchp_merra2_TransportTracers........................Execute Simulation....PASS
 
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 5
Execution tests failed: 0
Execution tests not yet completed: 0

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Furthermore, all integration tests were zero-diff w/r/t PR #1879:

Checking gchp_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_fullchem_benchmark
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_fullchem_RRTMG
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_tagO3
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_TransportTracers
   -> No differences in OutputDir
   -> No differences in Restarts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a bug that was previously reported topic: HEMCO Standalone Model Pertaining to the HEMCO standalone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bugfix] Longitudinal grids for HEMCO standalone (0.25 x 0.3125, 0.5 x 0.625)
1 participant