Allow up to 10 nested brackets in the HEMCO_Config.rc file #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Core/hco_config_mod.F90 - In routine "BracketCheck", changed the MAXBRACKNEST=5 setting to MAXBRACKNEST=10. This will allow up to 10 nested brackets in the HEMCO_Config.rc file. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
topic: Configuration Files
4 tasks
|
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #e43be93 GEOS-Chem submod update: Merge PR #2178 (Rename "native" to "raw" )
GEOS-Chem #67220bb52 Merge PR #2178 (Rename "native" to "raw" in GCHP rundir scripts)
HEMCO #7933a1b Increase allowed # of nested brackets from 5 to 10
Using 24 OpenMP threads
Number of execution tests: 26
Submitted as SLURM job: 23201447
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%Also, all integration tests were zero-diff w/r/t 14.3.0, except:
|
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #4bceb23 7GEOS-Chem submod update: Merge PR #2178 (Rename "native" to "raw" )
GEOS-Chem #67220bb52 Merge PR #2178 (Rename "native" to "raw" in GCHP rundir scripts)
HEMCO #7933a1b Increase allowed # of nested brackets from 5 to 10
Number of execution tests: 6
Submitted as SLURM job: 23202467
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%Furthermore, all GCHP integration tests were zero-diff w/r/t 14.3.0 |
lizziel
approved these changes
Mar 13, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
In this PR, we have updated the
MAXBRACKNESTparameter setting from 5 to 10 in theBracketCheckroutine ofsrc/Core/hco_config_mod.F90. This update is needed to account for additional nested brackets, because bracket conditions do not recognize the.and.operator.Expected changes
This is a zero-diff update. It should allow
HEMCO_Config.rcfiles with more than 5 nested brackets (such as we have in geoschem/geos-chem#2171) to be parsed without error.Related Github Issue(s)