Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excessive prints when using MPI #296

Merged

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Nov 7, 2024

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR fixes excessive prints about opening files with HEMCO that appear when using MPI. This update is relevant only for use of HEMCO read routines within MPI models.

Expected changes

This is a no diff update.

Reference(s)

None

Related Github Issue

None

@lizziel lizziel added topic: ESMF or MPI Related to issues in the ESMF and/or MPI environments category: Interface to External Model Related to HEMCO updates needed to interface with other models (GEOS, WRF, CESM, etc) labels Nov 7, 2024
@lizziel lizziel changed the title Restrict read prints if using MPI Log print updates for MPI and CESM Nov 15, 2024
@lizziel lizziel self-assigned this Nov 22, 2024
…EMCO

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel force-pushed the bugfix/reduce_hemco_read_prints_in_mpi branch from d663fc9 to ab94096 Compare December 3, 2024 17:18
@lizziel
Copy link
Contributor Author

lizziel commented Dec 3, 2024

I updated this PR to be simpler than the original. Now ready for review.

@lizziel lizziel marked this pull request as ready for review December 3, 2024 17:20
@lizziel lizziel changed the title Log print updates for MPI and CESM Remove excessive prints when using MPI Dec 3, 2024
@yantosca yantosca changed the base branch from main to dev/no-diff-to-benchmark December 3, 2024 17:29
@yantosca yantosca added this to the 3.10.1 milestone Dec 3, 2024
@yantosca yantosca self-requested a review December 3, 2024 17:30
@yantosca yantosca added the topic: Structural Modifications Related to HEMCO structural modifications (as opposed to scientific updates) label Dec 3, 2024
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizziel. This is good to merge.

@lizziel lizziel merged commit d00af43 into dev/no-diff-to-benchmark Dec 3, 2024
1 check passed
@lizziel lizziel deleted the bugfix/reduce_hemco_read_prints_in_mpi branch December 17, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Interface to External Model Related to HEMCO updates needed to interface with other models (GEOS, WRF, CESM, etc) topic: ESMF or MPI Related to issues in the ESMF and/or MPI environments topic: Structural Modifications Related to HEMCO structural modifications (as opposed to scientific updates)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants