Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to build and run in GEOS #300

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Fixes to build and run in GEOS #300

merged 3 commits into from
Dec 20, 2024

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Dec 20, 2024

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR contains small fixes for running this version of HEMCO in GEOS. Fixes include:

  • Remove printing HcoDiagn%MassScal since never set in the model and thus prints garbage values.
  • Update formatting in F77 file for dustdead extension. GEOS was failing build due to a line that was too long.

Expected changes

This is a no diff update.

Reference(s)

None

Related Github Issue

None

@lizziel
Fix F77 formatting in dustdead extension (.F not .F90)
73e3bf4 
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel
Remove print of ThisDiagn%MassScal which is never set in the model
d9a117e 
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel
Update changelog
e61ab90 
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel added category: Interface to External Model Related to HEMCO updates needed to interface with other models (GEOS, WRF, CESM, etc) topic: Structural Modifications Related to HEMCO structural modifications (as opposed to scientific updates) no-diff-to-benchmark This update will have no impact on benchmark simulations labels Dec 20, 2024
@lizziel lizziel added this to the 3.10.1 milestone Dec 20, 2024
@lizziel lizziel requested a review from yantosca December 20, 2024 21:02
@lizziel lizziel self-assigned this Dec 20, 2024
yantosca
yantosca approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge! Thanks @lizziel

@lizziel lizziel merged commit b94f2e0 into dev/no-diff-to-benchmark Dec 20, 2024
1 check passed
@lizziel lizziel deleted the bugfix/run_with_geos branch December 20, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yantosca yantosca yantosca approved these changes

Assignees

@lizziel lizziel

Labels
category: Interface to External Model Related to HEMCO updates needed to interface with other models (GEOS, WRF, CESM, etc) no-diff-to-benchmark This update will have no impact on benchmark simulations topic: Structural Modifications Related to HEMCO structural modifications (as opposed to scientific updates)
Projects
None yet
Milestone
3.10.1
Development

Successfully merging this pull request may close these issues.
2 participants
@lizziel @yantosca