Bug fix for stretched grid restart attribute check #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…start This update changes the conversion of input target lat and lon to avoid small differences with output target lat and lon written to the restart file. Both values are single precision but the conversion used double precision 180 when converting from degrees to radians. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
yantosca
changed the title
yantosca
added
bugfix
|
GCHP integration tests all passed: ==============================================================================
GCHP: Execution Test Results
GCHP #8b1f7ca GEOS-Chem submod update: Merge PR #2263 (Removed fixed date ranges)
GEOS-Chem #b54ad6df8 Merge PR #2263 (Remove hardcoded year range for met, restarts, BC)
HEMCO #fddcae5 Update version to 3.8.1 for release
Number of execution tests: 11
Submitted as SLURM job: 29493409
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a mismatch between stretched grid coordinates as computed from attributes in the restart file and in the configure files. Target lat/lon are read from file as REAL4 and written to checkpoint as REAL4. Conversion to radians, however, uses 180 degrees at double precision, while conversion back to lat/lon uses 180 degrees as single precision. This results in failing the online check that the coordinates are identical.
Please note that MAPL will have a major overhaul to MAPL3 soon. I am therefore applying the simplest fix to our fork only rather than change MAPL to compare lat/lon instead radians. However, I will check that the bug is not present in the MAPL3 development code.
closes geoschem/GCHP#404