Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG/ISSUE] Issue with cubed-sphere to cubed-sphere regridding #167

Closed
lizziel opened this issue Sep 27, 2022 · 2 comments
Closed

[BUG/ISSUE] Issue with cubed-sphere to cubed-sphere regridding #167

lizziel opened this issue Sep 27, 2022 · 2 comments
Assignees
@yantosca
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Cubed-Sphere Grid Pertains to cubed-sphere grids and/or regridding

Comments

@lizziel
Copy link
Contributor

lizziel commented Sep 27, 2022

There is currently a problem comparing GCHP output with different grid resolutions using the 1-yr full chemistry benchmark code, as is necessary for 14.0 (C24) which compares to 13.2 (C48). Cubed-sphere to cubed-sphere regridding needs to be tested further in GCPy. Apologies this github issue report does not have more detailed info. This is serving as a reminder for someone on GCST to take a look. The version is GCPy 1.2.0.
@lizziel lizziel added the category: Bug Something isn't working label Sep 27, 2022
@lizziel lizziel changed the title [BUG/ISSUE] [BUG/ISSUE] Issue with cubed-sphere to cubed-sphere regridding Sep 27, 2022
@yantosca yantosca added topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Cubed-Sphere Grid Pertains to cubed-sphere grids and/or regridding labels Oct 6, 2022
@stale
Copy link

stale bot commented Nov 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the stale No recent activity on this issue label Nov 9, 2022
@yantosca yantosca removed the stale No recent activity on this issue label Nov 9, 2022
@stale stale bot added the stale No recent activity on this issue label Dec 17, 2022
@lizziel lizziel added never stale Never label this issue as stale and removed stale No recent activity on this issue labels Dec 19, 2022
@geoschem geoschem deleted a comment from stale bot Aug 22, 2023
@yantosca yantosca self-assigned this Aug 22, 2023
@yantosca yantosca mentioned this issue Aug 22, 2023
Merged
yantosca added a commit that referenced this issue Aug 22, 2023
@yantosca
Merge PR #253 (Fix broken code in file_regrid.py; updated doc)
8e98d3f 
This merge brings PR #253 (Fixed broken regridding code in file_regrid.py;
Updated GCPy regridding documentation, by @yantosca) into the GCPy
1.4.0 development stream.

We have fixed several issues in the current gcpy/file_regrid.py script,
so that LL -> CS/SG, LL -> LL, CS/SG -> CS/SG, and CS/SG -> LL regridding
now work.  Furthermore, we have refactored the code in file_regrid.py
for clarity.

We have updated the Regridding.rst file and have added some extra
examples using file_regrid.py.  We have also verified that all examples
using file_regrid.py and regrid_restart_file.py work as advertised.

This will not affect benchmark code as the plotting routines
compare_zonal_mean() and compare_single_level() use the routine
regrid_comparison_data from gcpy/regrid.py.  Perhaps we can resolve
the issue reported in #167 with the knowledge thus gained in preparing
this PR.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@lizziel lizziel mentioned this issue Oct 10, 2023
Merged
@github-actions GitHub Actions
Copy link

Stale issue message

hannahnesser pushed a commit to hannahnesser/gcpy that referenced this issue Jan 22, 2024
@yantosca
Merge PR geoschem#253 (Fix broken code in file_regrid.py; updated doc)
0241248 
This merge brings PR geoschem#253 (Fixed broken regridding code in file_regrid.py;
Updated GCPy regridding documentation, by @yantosca) into the GCPy
1.4.0 development stream.

We have fixed several issues in the current gcpy/file_regrid.py script,
so that LL -> CS/SG, LL -> LL, CS/SG -> CS/SG, and CS/SG -> LL regridding
now work.  Furthermore, we have refactored the code in file_regrid.py
for clarity.

We have updated the Regridding.rst file and have added some extra
examples using file_regrid.py.  We have also verified that all examples
using file_regrid.py and regrid_restart_file.py work as advertised.

This will not affect benchmark code as the plotting routines
compare_zonal_mean() and compare_single_level() use the routine
regrid_comparison_data from gcpy/regrid.py.  Perhaps we can resolve
the issue reported in geoschem#167 with the knowledge thus gained in preparing
this PR.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@lizziel lizziel mentioned this issue Apr 9, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yantosca yantosca

Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Cubed-Sphere Grid Pertains to cubed-sphere grids and/or regridding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lizziel @yantosca