Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C2H2 and C2H4 to emissions_species.yml #208

Merged
merged 3 commits into from
Mar 17, 2023

Conversation

msulprizio
Copy link
Contributor

Mat Evans pointed out C2H2 and C2H4 were missing from the emissions tables in 1-month and 1-year full-chemistry benchmark output. This is corrected by listing these species in emission_species.yml.

Here we also update species_database.yml to be consistent with the current file in the GEOS-Chem 14.2.0 development branch.

@msulprizio msulprizio added the category: Bug Something isn't working label Mar 17, 2023
@msulprizio msulprizio added this to the 1.4.0 milestone Mar 17, 2023
@msulprizio msulprizio requested a review from yantosca March 17, 2023 16:49
@msulprizio msulprizio self-assigned this Mar 17, 2023
Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds C2H2/C2H4 to the emission species config file so that emissions totals will be included. Also the species_database.yml is up to date. Good to merge.

@msulprizio msulprizio merged commit 4f70859 into dev Mar 17, 2023
@msulprizio msulprizio deleted the feature/add-c2h2-c2h4-emis branch March 17, 2023 17:37
@yantosca yantosca added category: Bug Fix Fixes a bug that was previously reported topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output and removed category: Bug Something isn't working labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a bug that was previously reported topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants