-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pegged version numbers for the GCPy environment; Also add testing environment without pegged versions; Updated GitHub actions #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/environment_files/environment.yml - Now use pegged package versions, as described in issue #284 Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
docs/environment_files/testing.yml - Add this new environment file, based on the environment.yml file, but without pegged version numbers for most packages. .github/workflows/build-test-environment.yml - YAML config file to start a new GitHub action to build the mamba environment from "testing.yml" .github/workflows/build-gcpy-environment.yml - Updated names and comments - Now read docs/environment_files/environment.yml CHANGEKOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
topic: User Environment
Relating to python and/or conda environment
category: Bug Fix
Fixes a bug that was previously reported
labels
Jan 25, 2024
.github/workflows/build-gcpy-environment - Now attempt to build the environment with Python versions 3.8 thru 3.13. CHANGELOG.md - Updated currently Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
lizziel
reviewed
Jan 26, 2024
docs/environment_files/testing.yml
Outdated
# GCPy testing environment file. | ||
# Intended to be used by the GCST for testing purposes. | ||
# | ||
# GCPy users should build the environmet from "environment.yml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: environment
lizziel
requested changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo to fix. Otherwise good to merge!
docs/environment_files/testing.yml - Fixed typo: "environmet" -> "environment" in comments - Now peg the RTD package versions, as we know these work. - Also peg matplotlib>=3.8 Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: Bug Fix
Fixes a bug that was previously reported
topic: User Environment
Relating to python and/or conda environment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
This is the companion PR to #284. It does the following:
docs/environment_files/environment.yml
to use pegged package versions.docs/environment_files/testing.yml
to specify an environment without pegged package versions. This can be used to evaluate future incompatibilities caused by package updates.build-test-environment
to check the environment specified intesting.yml
.Expected changes
This is a zero-diff update. It should now allow for easier installation of GCPy across different platforms due to the pegged versions. Also, installation with pegged versions is much faster.
Reference(s)
N/A
Related Github Issue(s)