Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in GCC vs GCHP transport tracer benchmark mass tables #300

Merged
merged 2 commits into from
Feb 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
### Fixed
- CS inquiry functions in `gcpy/cstools.py` now work properly for `xr.Dataset` and `xr.DataArray` objects
- Prevent an import error by using `seaborn-v0_8-darkgrid` in`gcpy/benchmark/modules/benchmark_models_vs_obs.py`
- Fixed silent bug in transport tracer benchmark GCC vs GCHP mass tables preventing them from being generated

## [1.4.2] - 2024-01-26
### Added
Expand Down
18 changes: 16 additions & 2 deletions gcpy/benchmark/modules/run_1yr_tt_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ def run_benchmark(config, bmk_year_ref, bmk_year_dev):
)
gchp_vs_gcc_refrstdir = os.path.join(
config["paths"]["main_dir"],
config["data"]["ref"]["gchp"]["dir"],
config["data"]["ref"]["gchp"]["restarts_subdir"]
config["data"]["ref"]["gcc"]["dir"],
config["data"]["ref"]["gcc"]["restarts_subdir"]
)
gchp_vs_gchp_refrstdir = os.path.join(
config["paths"]["main_dir"],
Expand Down Expand Up @@ -810,6 +810,20 @@ def gchp_vs_gcc_mass_table(mon):
"is_pre_14.0"]
)

# Create tables
bmk.make_benchmark_mass_tables(
refpath,
gchp_vs_gcc_refstr,
devpath,
gchp_vs_gcc_devstr,
dst=gchp_vs_gcc_tablesdir,
subdst=bmk_mon_yr_strs_dev[mon],
label=f"at 01{bmk_mon_yr_strs_dev[mon]}",
overwrite=True,
spcdb_dir=spcdb_dir,
dev_met_extra=devareapath
)

# Create tables in parallel
# Turn off parallelization if n_jobs==1
if config["options"]["n_cores"] != 1:
Expand Down
Loading