Bug fix for TOMAS sulfate production rates #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue. |
|
Hi @msulprizio - these updates are ready to be implemented as is. This fix is an important one to enable TOMAS to run correctly with the in-cloud sulfate chemistry migrated into KPP. Can you assist with this update and can we add a never stale label? |
msulprizio
added
never stale
|
@BettyCroft Sure thing. We plan to implement this shortly after 14.1.0 is released -- it's in the benchmark stages now. |
|
Thanks @msulprizio! |
msulprizio
changed the title
msulprizio
approved these changes
Mar 20, 2023
msulprizio
added a commit
that referenced
this pull request
Apr 7, 2023
In pull request #1569, PH2SO4 and PSO4AQ were added as species in fullchem.eqn but were never defined in species_database.yml. This led to an error when registering species in state_chm_mod.F90 Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
|
Thank you @msulprizio ! |
This was referenced Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates are a bug fix for TOMAS sulfate production rates as discussed in issue #1511. With the migration of sulfate chemistry to KPP, TOMAS does not have the correct sulfate production rates in v14. Primary updates are to KPP/fullchem/fullchem.eqn and GeosCore/fullchem_mod.F90 and tomas_mod.F90. Two new species are added in fullchem.eqn PSO4AQ and PH2SO4 and KPP was rebuilt. These species are not in the GC restart file - so replace EFYO with CYS for the SPC_ in HEMCO_COnfig.rc for the simulation to run.