Add fix to cldj_interface_mod.F90 to avoid floating-point exception in GCHP integration tests #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n GCHP
The following line in GeosCore/cldj_interface_mod.F90 was causing a floating-
point exception error in GCHP integration tests:
! Set top of atmosphere relative humidity to 10% of layer below
RRR(State_Grid%NZ+1) = RRR(State_Grid%NZ) * 1.d-1
This is resolved by moving the lines for setting RRR to before the loop
over the number of layers with clouds.
Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
lizziel
requested changes
Jan 9, 2024
GeosCore/cldj_interface_mod.F90
Outdated
| @@ -483,6 +483,11 @@ SUBROUTINE Run_CloudJ( Input_Opt, State_Chm, State_Diag, & | |||
| CLDF(1:State_Grid%NZ) = State_Met%CLDF(I,J,1:State_Grid%NZ) | |||
| CLDF(State_Grid%NZ+1) = CLDF(State_Grid%NZ) | |||
|
|
|||
| ! Set humidity from input meteorology field | |||
| ! Convert relative humidity [unitless] from percent to fraction | |||
There was a problem hiding this comment.
Add one more comment: "! Set top of atmosphere relative humidity to 10% of layer below"
There was a problem hiding this comment.
Thanks for catching that. It's now added in 326c63c.
Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
lizziel
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard/GCST
Describe the update
The following line in GeosCore/cldj_interface_mod.F90 was causing a floating- point exception error in GCHP integration tests:
This is resolved by moving the lines for setting RRR to before the loop over the number of layers with clouds.
Please provide a clear and concise overview of the update.
Expected changes
@lizziel wrote:
Related Github Issue(s)