Add budget diagnostic option for fixed level vertical region #2127

lizziel · 2024-01-17T22:19:18Z

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR brings a new budget diagnostic category. More details coming soon. This update is built off of dev/14.3.0 and so can go into 14.3.1 if we have one.

Expected changes

This is a no diff update.

Reference(s)

None

Related Github Issue(s)

This PR is somewhat related to updates going into the model for the trop and PBL budget diagnostics. Those diagnostics
have been fixed levels but will not longer be fixed level after an update in the pipeline to incorporate dynamic top layer.
#2002

This PR also goes with a GCPy update to include the fixed level diagnostic in the budget table:
geoschem/gcpy#304

lizziel · 2024-02-06T19:41:58Z

All integration tests pass. I am updating the GCPy operations budget table to inspect results of a test run.

lizziel · 2024-02-12T19:03:31Z

I did a test of setting Trop budget diagnostic top-level 35 and then creating the budget table for both Trop and Levs1to35 diagnostics. The results are identical:

Trop [Gg] : O3
+--------------+------------+------------+---------+------------+
| Operation    |        Ref |        Dev |    Diff |   Pct_diff |
|--------------+------------+------------+---------+------------|
| Chemistry    |  -26.38109 |  -26.38109 | 0.00000 |   -0.00000 |
| Convection   |    0.00007 |    0.00007 | 0.00000 |    0.00000 |
| EmisDryDep   |   -0.00000 |   -0.00000 | 0.00000 |   -0.00000 |
| Mixing       | -105.73124 | -105.73124 | 0.00000 |   -0.00000 |
| Transport    |   17.13633 |   17.13633 | 0.00000 |    0.00000 |
| WetDep       |    0.00000 |    0.00000 | 0.00000 |  nan       |
| ACCUMULATION | -114.97593 | -114.97593 | 0.00000 |   -0.00000 |
+--------------+------------+------------+---------+------------+
Levs1to35 [Gg] : O3
+--------------+------------+------------+---------+------------+
| Operation    |        Ref |        Dev |    Diff |   Pct_diff |
|--------------+------------+------------+---------+------------|
| Chemistry    |  -26.38109 |  -26.38109 | 0.00000 |   -0.00000 |
| Convection   |    0.00007 |    0.00007 | 0.00000 |    0.00000 |
| EmisDryDep   |   -0.00000 |   -0.00000 | 0.00000 |   -0.00000 |
| Mixing       | -105.73124 | -105.73124 | 0.00000 |   -0.00000 |
| Transport    |   17.13633 |   17.13633 | 0.00000 |    0.00000 |
| WetDep       |    0.00000 |    0.00000 | 0.00000 |  nan       |
| ACCUMULATION | -114.97593 | -114.97593 | 0.00000 |   -0.00000 |
+--------------+------------+------------+---------+------------+

I also did a 1-month run and checked that the Levs1to35 diagnostic is near but not quite equal to the Trop diagnostic. This is expected because the top level of the Trop diagnostic is dynamic.

yantosca

Thanks @lizziel! We just need a changelog update and then I can merge this into the no-diff-to-benchmark branch.

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

…nostic Default setting in all templates is levels 1 to 35. Users can change the name to change the levels. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

The top and bottom levels strings are read from the diagnostic names in HISTORY.rc and use to loop over levels in the vertical region when computing budget diagnostics. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

Error traps are now set to catch the following problems in HISTORY.rc: - Missing bottom or top level - Mismatch between either bottom or top across all diagnostics (Level range must be the same for all of the budget level range diags) - Bottom level less than or equal to 0 - Bottom level greater than top level - Top level greater than number of model levels

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

Users can add additional species as needed Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

yantosca

Good to merge!

yantosca · 2024-02-13T20:11:59Z

Integration tests are running

yantosca · 2024-02-13T21:35:31Z

All GEOS-Chem Classic integration tests passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #8c0eab8 Merge PR #2138 and PR #2100 (Update operational run scripts)
GEOS-Chem #6e7c0de64 Merge PR #2127 (Add budget diag option for fixed level vertical region)
HEMCO     #f807e1a Update HEMCO version number to 3.8.0 in preparation for release

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 19589087
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Furthermore, all integration tests were zero-diff w/r/t 14.3.0, except for:

APM (Known parallelization issue)
RRTMG (numerical noise in RRTMG collection)

yantosca · 2024-02-13T21:55:31Z

All GCHP integration tests also passed:

==============================================================================
GCHP: Execution Test Results

GCHP      #eafac30 Merge PR #2138 and PR #2100 (Update operational run scripts)
GEOS-Chem #6e7c0de64 Merge PR #2127 (Add budget diag option for fixed level vertical region)
HEMCO     #f807e1a Update HEMCO version number to 3.8.0 in preparation for release

Number of execution tests: 6

Submitted as SLURM job: 19591288
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Furthermore, all GCHP integration tests were zero-diff w/r/t 14.3.0.

lizziel added topic: Diagnostics Related to output diagnostic data no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations labels Jan 17, 2024

lizziel changed the base branch from main to dev/14.3.0 January 17, 2024 22:19

lizziel changed the base branch from dev/14.3.0 to dev/no-diff-to-benchmark January 17, 2024 22:20

lizziel mentioned this pull request Feb 2, 2024

Reduce entries in GCHP HISTORY.rc #2142

Closed

lizziel force-pushed the feature/budget_diag_fixed_levels branch from ec75e0e to f3d8181 Compare February 5, 2024 20:14

lizziel changed the base branch from dev/no-diff-to-benchmark to dev/14.3.0 February 6, 2024 15:30

lizziel changed the base branch from dev/14.3.0 to main February 6, 2024 17:12

lizziel added this to the 14.3.1 milestone Feb 6, 2024

lizziel mentioned this pull request Feb 6, 2024

Capture all tropopause and PBL height changes in budget diagnostics #2103

Open

lizziel force-pushed the feature/budget_diag_fixed_levels branch from f3d8181 to 4857cea Compare February 6, 2024 19:38

lizziel mentioned this pull request Feb 12, 2024

Add fixed level diagnostic to operations budget table geoschem/gcpy#304

Merged

lizziel marked this pull request as ready for review February 12, 2024 19:03

lizziel requested a review from yantosca February 12, 2024 19:03

yantosca changed the base branch from main to dev/no-diff-to-benchmark February 12, 2024 19:46

yantosca requested changes Feb 13, 2024

View reviewed changes

lizziel added 12 commits February 13, 2024 14:35

Add fixed level budget diagnostic arrays to State_Diag object

e6effb1

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

Add fixed level diagnostic computation to Compute_Budget_Diagnostics

e2bb1f5

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

Add fixed level region budget diagnostic to all compute budget calls

82e0f3f

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

Pass state_diag to subroutine that computes budget diagnostics

b50eb6e

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

Use int and str suffixes for budget diagnostic top and bottom level vars

55f58e6

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

Updates HISTORY.rc templates to include fixed level range budget diag…

7638f23

…nostic Default setting in all templates is levels 1 to 35. Users can change the name to change the levels. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

Fix bug where only convection budget levs diag updated

2bfe568

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

Reorganize the GCHP transport tracer budget entries in HISTORY.rc

ffe6769

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

Reduce GCHP fullchem budget diagnostics in HISTORY.rc to ozone only

143adb8

Users can add additional species as needed Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

Update changelog

11c441e

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>

lizziel force-pushed the feature/budget_diag_fixed_levels branch from 4857cea to 11c441e Compare February 13, 2024 19:37

yantosca approved these changes Feb 13, 2024

View reviewed changes

yantosca merged commit 6e7c0de into dev/no-diff-to-benchmark Feb 13, 2024

yantosca deleted the feature/budget_diag_fixed_levels branch February 13, 2024 21:59

yantosca mentioned this pull request Feb 16, 2024

Process contribution to concentration of PM2.5 in GEOS-Chem #2157

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add budget diagnostic option for fixed level vertical region #2127

Add budget diagnostic option for fixed level vertical region #2127

lizziel commented Jan 17, 2024 •

edited

Loading

lizziel commented Feb 6, 2024

lizziel commented Feb 12, 2024

yantosca left a comment

yantosca left a comment

yantosca commented Feb 13, 2024

yantosca commented Feb 13, 2024 •

edited

Loading

yantosca commented Feb 13, 2024 •

edited

Loading

Add budget diagnostic option for fixed level vertical region #2127

Add budget diagnostic option for fixed level vertical region #2127

Conversation

lizziel commented Jan 17, 2024 • edited Loading

Name and Institution (Required)

Describe the update

Expected changes

Reference(s)

Related Github Issue(s)

lizziel commented Feb 6, 2024

lizziel commented Feb 12, 2024

yantosca left a comment

Choose a reason for hiding this comment

yantosca left a comment

Choose a reason for hiding this comment

yantosca commented Feb 13, 2024

yantosca commented Feb 13, 2024 • edited Loading

yantosca commented Feb 13, 2024 • edited Loading

lizziel commented Jan 17, 2024 •

edited

Loading

yantosca commented Feb 13, 2024 •

edited

Loading

yantosca commented Feb 13, 2024 •

edited

Loading