Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to run GEOS-Chem 14.3 in GEOS #2155

Merged

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Feb 15, 2024

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR contains updates to allow building and running GEOS-Chem 14.3 in GEOS. Changes include:

  • Fix unit conversions in GEOS-only code
  • Change exponent 'e' to 'd' to prevent build error due to incorrect precision
  • Change path to Cloud-J within GEOS config file geoschem_config.yml

Expected changes

This is a no-diff update for GCHP and GC-Classic.

Reference(s)

None

Related Github Issue(s)

None

@lizziel lizziel added the category: Interface to External Model Related to GEOS-Chem updates needed to interface with other models label Feb 15, 2024
@lizziel lizziel requested a review from yantosca February 15, 2024 16:35
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizziel. I just have a request to modify the KPP .eqn files rather than gckpp_Rates.F90 directly and then to rebuild the mechanism. I can do this for you if you like.

CHANGELOG.md Show resolved Hide resolved
KPP/fullchem/gckpp_Rates.F90 Show resolved Hide resolved
@yantosca yantosca self-assigned this Feb 15, 2024
@yantosca yantosca added this to the 14.3.1 milestone Feb 15, 2024
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel force-pushed the bugfix/fixes_for_geoschem_14.3_in_geos branch from 5aa0bc6 to ac1da8d Compare February 15, 2024 16:48
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge. Thanks @lizziel!

@yantosca yantosca added the category: Bug Fix Fixes a previously-reported bug label Feb 15, 2024
@yantosca
Copy link
Contributor

Now merged (locally) into dev/no-diff-to-benchmark and running integration tests

@yantosca
Copy link
Contributor

All GEOS-Chem Classic integration tests passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #35c6d37 GEOS-Chem submod update (Merge PR #2127: Ops budgets btw 2 fixed levels)
GEOS-Chem #ea4e1e456 Merge PR #2155 (Fixes to run GEOS-Chem 14.3 in GEOS)
HEMCO     #f807e1a Update HEMCO version number to 3.8.0 in preparation for release

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 19871045
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also, all integration tests were zero-diff w/r/t 14.3.0 except:

  • APM (known parallelization error)
  • RRTMG (numerical noise in RRTMG collection output)

@yantosca
Copy link
Contributor

yantosca commented Feb 15, 2024

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCHP      #6746fb0 GEOS-Chem submod update (Merge PR #2127: Ops budgets btw 2 fixed levels)
GEOS-Chem #ea4e1e456 Merge PR #2155 (Fixes to run GEOS-Chem 14.3 in GEOS)
HEMCO     #f807e1a Update HEMCO version number to 3.8.0 in preparation for release

Number of execution tests: 6

Submitted as SLURM job: 19871180
==============================================================================
 
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

All integration tests were also zero-diff w/r/t 14.3.0.

@yantosca yantosca merged commit b0fc61a into dev/no-diff-to-benchmark Feb 15, 2024
@yantosca yantosca deleted the bugfix/fixes_for_geoschem_14.3_in_geos branch February 15, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a previously-reported bug category: Interface to External Model Related to GEOS-Chem updates needed to interface with other models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants