Add #SBATCH -c 1 to Harvard Cannon GCHP run scripts and integration tests; Also allow scheduler none in integration tests
#2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent SLURM update on the Harvard Cannon cluster now requires MPI jobs (such as GCHP) to specify the "#SBATCH -c 1" (which sets the SLURM_TRES_PER_TASK=cpu:1. Otherwise, an error will occur when submitting the batch job from an interactive session, as the value of SLURM_TRES_PER_TASK will be copied from the interactive session, which will prevent the batch job from starting. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
test/integration/GCHP/integrationTestExecute.sh
- Add "#SBATCH -c 1" tag for SLURM scheduler. This is needed after a
recent SLURM update on the Harvard Cannon cluster.
test/integration/GCClassic/integrationTest.sh
test/integration/GCHP/integrationTest.sh
- Add IF block to ask user if they would like to proceed with
compile-only tests when scheduler = "none"
- Update usage message to denote which schedulers are allowed
("SLURM|LSF|none")
- Remove "#SBATCH -c 1" from integrationTestExecute.sh when
scheduler is "LSF"
CHANGELOG.md
- Updated accordingly
Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
topic: Benchmarking and Testing
1 task
msulprizio
approved these changes
Mar 7, 2024
|
All GCClassic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #df7ad84 GEOS-Chem submod update: Merge PR #2177 (ObsPack bug fixes )
GEOS-Chem #d95a1bd48 Add "#SBATCH -c 1" to GCHP integration test scripts (for SLURM)
HEMCO #f807e1a Update HEMCO version number to 3.8.0 in preparation for release
Using 24 OpenMP threads
Number of execution tests: 26
Submitted as SLURM job: 22670182
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%Furthermore, all integration tests were zero-diff w/r/t 14.3.0, except
|
lizziel
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Looks good! My feature request also asked for scheduler to be a required arguement when running integration tests. Otherwise you can forget to add it and then wonder why only compile tests were run. We can discuss that more on the feature request page. If we put it in it does not need to be part of this PR.
Thanks @llzziel. So I can add another if block for scheduler == none and then error out as the default. Sorry I missed that! |
test/integration/GCClassic/integrationTest.sh test/integration/GCHP/integrationTest.sh - Remove the default 'scheduler="none"' setting. We now rely on the value passed via the arg list - Add note that scheduler is converted to uppercase (this was always the default behavior but not documented) - Add if block to exit with usage message if scheduler is omitted. - Add comment to state that compile-only tests will run when scheduler is "none". CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
|
@lizziel, @msulprizio: We now exit if scheduler is not passed, see commit b93fe8c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
This PR does the following:
Adds
#SBATCH -c 1to Harvard Cannon integration test scripts and GCHP run scripts. This is a necessary hotfix to allow GCHP run and integration test jobs to be submitted from within a SLURM interactive session. A recent update to SLURM on the Harvard Cannon introduced this new behavior ("It's a feature, not a bug!")Implements the feature request raised by @lizziel in issue [FEATURE REQUEST] Require scheduler entry in integration tests #2147. We now allow integration tests to use
-s noneto set the scheduler to "none". In this case, this will invoke compile-only tests. The user will be queried whether to accept or reject this. Also the usage message has been updated to show the potential values of the-sargument.Expected changes
-s none.Related Github Issue(s)