Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uptake coefficients on stratospheric aerosol #2205

Merged

Conversation

cdholmes
Copy link
Contributor

Name and Institution

Name: Christopher Holmes
Institution: FSU

Describe the update

This PR addresses the bug identified in issue #2204

Corrected the formula for 1st order heterogeneous chemical loss on stratospheric aerosol for a few species. The affected species are NO2, NO3, and VOC that experience heterogeneous loss on aerosol.

Expected changes

The fix should increase heterogeneous losses of NO2, NO3 and VOC species in the stratosphere. The overall impact on VOC should be small as there is little VOC in the stratosphere. The additional loss of NO2 and NO3 should also increase stratospheric HNO3. I have not benchmarked the impact of this bugfix.

Related Github Issue(s)

See issue #2204.

Corrected the formula for 1st order
heterogeneous chemical loss on stratospheric aerosol for a few species.
The affected species are NO2, NO3, and VOC that experience heterogeneous loss on aerosol.
The fix should increase heterogeneous losses of these species in the stratosphere.
The overall impact on VOC should be small as there is little VOC in the stratosphere.
The additional loss of NO2 and NO3 should also increase stratospheric HNO3.
@cdholmes
Copy link
Contributor Author

I will notify the Stratosphere WG chairs of this bug fix in case they have any comments before merging.

@yantosca
Copy link
Contributor

Thanks @cdholmes, I will hold off merging until we get the all-clear.

@yantosca yantosca self-requested a review March 18, 2024 19:43
@yantosca yantosca self-assigned this Mar 18, 2024
@yantosca yantosca added topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms category: Bug Fix Fixes a previously-reported bug Strat WG labels Mar 18, 2024
@yantosca yantosca changed the base branch from main to dev/14.4.0 March 18, 2024 19:45
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to merge. I'll add a changelog update. Will run integration tests in the meantime.

@yantosca yantosca added this to the 14.4.0 milestone Mar 19, 2024
@yantosca yantosca linked an issue Mar 19, 2024 that may be closed by this pull request
yantosca added a commit that referenced this pull request Mar 19, 2024
CHANGELOG.md
- Added note about the bugfix for strat aerosol uptake applied in
  PR #2205

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca added a commit that referenced this pull request Mar 19, 2024
KPP/fullchem/fullchem_RateLawFuncs.F90
- Fixed typo: "Arw_L1K" -> "Ars_L1K"

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca
Copy link
Contributor

All GEOS-Chem Classic integration tests passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #ac68980 GEOS-Chem submodule update: Merge PR #2198 (updated volcano emissions)
GEOS-Chem #ced31f725 PR #2205 post-merge fix: Fixed typo in fullchem_RateLawFuncs.F90
HEMCO     #f807e1a Update HEMCO version number to 3.8.0 in preparation for release

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 24034739
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

@yantosca
Copy link
Contributor

All GCHP integration tests passed

==============================================================================
GCHP: Execution Test Results

GCHP      #53363f1 GEOS-Chem submodule update: Merge PR #2198 (updated volcano emissions)
GEOS-Chem #ced31f725 PR #2205 post-merge fix: Fixed typo in fullchem_RateLawFuncs.F90
HEMCO     #f807e1a Update HEMCO version number to 3.8.0 in preparation for release

Number of execution tests: 6

Submitted as SLURM job: 24066221
==============================================================================
 

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

@yantosca yantosca merged commit 679d534 into geoschem:dev/14.4.0 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a previously-reported bug topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Likely bug in heterogeneous chemistry on stratospheric aerosol
2 participants