Remove hardcoded year range for met fields, restart, and BC files in HEMCO_Config.rc #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HEMCO_Config.rc Previously, entries for meteorology fields, restart files, and boundary condition files were hardcoded for year ranges in HEMCO_Config.rc (e.g. 1980-2021/1-12/1-31/*). This required updating the end year each time a new calendar year became available. We are able to avoid this by changing the time range entries to use year, month, and day tokens in HEMCO_Config.rc instead (e.g. $YYYY/$MM/$DD/*). Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
msulprizio
added
category: Feature Request
|
This update passes GCClassic integration tests and results in zero differences. It does not impact GCHP. |
yantosca
approved these changes
Apr 22, 2024
|
@msulprizio: Integration tests are running |
|
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #25e5fa5 GEOS-Chem submod update: Merge PR #2072 (Optimized unit conversions)
GEOS-Chem #b54ad6df8 Merge PR #2263 (Remove hardcoded year range for met, restarts, BC)
HEMCO #fddcae5 Update version to 3.8.1 for release
Using 24 OpenMP threads
Number of execution tests: 29
Submitted as SLURM job: 29444934
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
|
All GCHP execution tests passed as well. ==============================================================================
GCHP: Execution Test Results
GCHP #79397ad GEOS-Chem submod update: Merge PR #2072 (Optimized unit conversions)
GEOS-Chem #7552943b6 Merge 14.4.0-alpha.13 into the bugfix/carbon-gchp-extdata branch
HEMCO #fddcae5 Update version to 3.8.1 for release
Number of execution tests: 11
Submitted as SLURM job: 29360121
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
yantosca
pushed a commit
that referenced
this pull request
Jun 25, 2024
This merge brings PR #2347 (Use hard-coded dates for meteorological fields and boundary conditions, by @nicholasbalasus) into the GEOS-Chem "no-diff-to-benchmark" development stream. This PR fixes a bug that was implemented in PR #2263. It should improve the performance by preventing excessive reading of met fields/BCs. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard
Describe the update
Previously, entries for meteorology fields, restart files, and boundary condition files were hardcoded for year ranges in HEMCO_Config.rc (e.g. 11980-2021/1-12/1-31/*1). This required updating the end year each time a new calendar year became available. We are able to avoid this by changing the time range entries to use year, month, and day tokens in HEMCO_Config.rc instead (e.g. 1$YYYY/$MM/$DD/*1).
Expected changes
This is a zero difference update