Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filename for CMIP6 aircraft emissions in HEMCO_Config.rc.template #2317

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

ltmurray
Copy link
Contributor

Name and Institution (Required)

Name: Lee Murray
Institution: University of Rochester

Describe the update

Fix the name of the CMIP6 aircraft input files in the HEMCO_Config.rc template

Expected changes

GCAP2 runs will be able to locate and download the CMIP6 aircraft files once again

Reference(s)

N/A

Related Github Issue

N/A.

@yantosca
Copy link
Contributor

Thanks @ltmurray. We can get this into the no-diff-to-benchmark branch.

@yantosca yantosca changed the base branch from main to dev/no-diff-to-benchmark June 10, 2024 18:59
@yantosca yantosca self-assigned this Jun 10, 2024
@yantosca yantosca added topic: Configuration Files Related to GEOS-Chem configuration files category: Bug Fix Fixes a previously-reported bug topic: GCAP2 Meteorology Related to simulations using GCAP2 meteorology no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations labels Jun 10, 2024
@yantosca yantosca self-requested a review June 11, 2024 15:00
@yantosca yantosca added this to the 14.4.1 milestone Jun 11, 2024
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge, as it just fixes a typo. Integration tests are running.

@yantosca
Copy link
Contributor

All GEOS-Chem Classic integration tests passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #25e76db HEMCO submod update: Merge PR #280 (Fix stale.yml file)
GEOS-Chem #494512a5b Add CHANGELOG update for typo in HEMCO_Config.fullchem
HEMCO     #55d27e2 Merge PR #280 (Now use comma-separated list in stale.yml )

Using 24 OpenMP threads
Number of execution tests: 28

Submitted as SLURM job: 35656832
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also, all GEOS-Chem Classic integration tests were zero-diff w/r/t the 14.4.0 release, except:

  • TOMAS15 (possible parallelization issue)
  • APM (known parallelization issue)

@yantosca
Copy link
Contributor

yantosca commented Jun 11, 2024

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCHP      #2c13ddd HEMCO submod update: Merge PR #280 (Fix stale.yml file)
GEOS-Chem #494512a5b Add CHANGELOG update for typo in HEMCO_Config.fullchem
HEMCO     #

Number of execution tests: 11

Submitted as SLURM job: 35656989
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also, all GCHP integration tests were zero-diff w/r/t the 14.4.0 release.

yantosca added a commit that referenced this pull request Jun 11, 2024
This merge brings PR #2317 (Fix filename for CMIP6 aircraft emissions in
HEMCO_Config.rc.template, by @ltmurray) into the GEOS-Chem
"no-diff-to-benchmark" development stream.

This PR fixes a typo in the HEMCO_Config.rc for CMIP6 aircraft
emssions.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca merged commit afc5963 into geoschem:dev/no-diff-to-benchmark Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a previously-reported bug no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Configuration Files Related to GEOS-Chem configuration files topic: GCAP2 Meteorology Related to simulations using GCAP2 meteorology
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants