Changes for GEOS-Chem v14.4 within CESM compatibility #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizziel
added
category: Interface to External Model
lizziel
requested changes
Jun 25, 2024
| @@ -4139,7 +4139,6 @@ SUBROUTINE NOXCOEFF_INIT( Input_Opt, State_Grid, State_Chm ) | |||
| #if defined( MODEL_CESM ) | |||
| ENDIF | |||
|
|
|||
| CALL MPI_BCAST( State_Chm%NOXCOEFF, nSize, mpi_real8, masterprocid, mpicom, ierr ) | |||
There was a problem hiding this comment.
The error catch right below this line should be removed as well.
There was a problem hiding this comment.
Thanks Lizzie, I also got rid of all the unnecessary variable definitions.
lizziel
approved these changes
Jun 25, 2024
|
Thanks @lizzie and @jimmielin! I'll pull this into no-diff-to-benchmark. |
9 tasks
|
All GCClassic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #220f810 GEOS-Chem submod update: Merge PR #2346 and PR #2349 (Fixes for CESM)
GEOS-Chem #40a0723cc Merge PR #2348 (Changes for 14.4.0 within CESM compatibility)
HEMCO #55d27e2 Merge PR #280 (Now use comma-separated list in stale.yml )
Using 24 OpenMP threads
Number of execution tests: 28
Submitted as SLURM job: 37492456
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%Furthermore, all tests were zero-diff w/r/t PR #2346 and PR #2349, except:
|
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #97d30de GEOS-Chem submod update: Merge PR #2346 and PR #2349 (Fixes for CESM)
GEOS-Chem #40a0723cc Merge PR #2348 (Changes for 14.4.0 within CESM compatibility)
HEMCO #
Number of execution tests: 11
Submitted as SLURM job: 37493005
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
yantosca
added a commit
that referenced
this pull request
Jun 25, 2024
This merge brings PR #2348 (Changes for GEOS-Chem v14.4 within CESM compatibility, by @jimmielin) into the GEOS-Chem "no-diff-to-benchmark" development stream. This PR fixes a few minor issues in the GEOS-Chem to CESM interface. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Haipeng Lin
Institution: Harvard Univ.
Describe the update
These are updates that only affect GEOS-Chem within CESM to make the model compatible with coupling to CESM.
There are several (minor) changes bundled in this update.
GeosCore/ucx_mod.F90: removeMPI_Bcastcall. This was previously removed in Updates for GEOS-Chem within CESM2 - convective scavenging correction and MPI fixes #1993 but was somehow regressed in the latest version.run/CESM/geoschem_config.yml: Alphabetical ordering of complex SOA species. Therun/CESMconfig file is not generated by the run directory script, but the run directory script is also updated in Correct alphabetical order of complex SOA species in geoschem_config.yml #2346 for consistency across versions.run/CESM/HEMCO_Config.rc: disable ParaNOx extension by default in CESM due to causing issues.Expected changes
Affects GEOS-Chem within CESM only.
Reference(s)
N/A
Related Github Issue
Companion PR in geoschem/CAM development repository for GEOS-Chem within CESM: geoschem/CAM#34
Tagging @lizziel. Thanks!