Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simulation with all diagnostics turned to integration testing #2399

Merged
merged 20 commits into from
Aug 1, 2024
Merged

Add simulation with all diagnostics turned to integration testing #2399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f6dc400
Add full-chemistry simulation with all diagnostics turned on in HISTO…
msulprizio Jul 24, 2024
1fe1dec
Add missing fields for UVFlux collection in HISTORY.rc.fullchem
yantosca Jul 26, 2024
d67ff08
Update logic to reset of frequency & declaration in HISTORY.rc files
yantosca Jul 26, 2024
866a7c0
Use a function to print submodule hashes in integration tests
yantosca Jul 26, 2024
1f97c9e
Tweak the display of submod head commits for GCHP int tests
yantosca Jul 26, 2024
0f3997d
Remove debug exit statement from GCHP integrationTestCreate.sh
yantosca Jul 26, 2024
3681777
Add gchp_merra2_fullchem_alldiags integration test
yantosca Jul 26, 2024
f609171
Enable planeflight output in gc_4x5_merra2_fullchem_alldiags tests
yantosca Jul 29, 2024
3efd4d5
Rename ObsPack input file name in geoschem_config.yml templates
yantosca Jul 29, 2024
3a90c77
Also print superproject hash to integration test logs
yantosca Jul 29, 2024
3735779
Bug fix: Copy proper obspack file to alldiags test directory
yantosca Jul 29, 2024
03a25c3
Bug fix: Use ${HOME} instead of ~ in grep command
yantosca Jul 29, 2024
dc61470
Bug fix: GCHP budget diagnostic now uses SO4 instead of O3
yantosca Jul 30, 2024
5ab0237
GCHP integration tests now reset cap_restart time to 000000 UTC
yantosca Jul 30, 2024
023508a
Compare tag names in uppercase in routine Get_UVFlux_Bin
yantosca Jul 30, 2024
3f3929f
Disable the StratBM collection for the GCHP alldiags test
yantosca Jul 30, 2024
dcc8809
Add missing "_" to GCHP DryDep collection entries
yantosca Jul 30, 2024
9d766c4
Fix issues in GCHP emissions collection; disable UVFlux in alldiags test
yantosca Jul 31, 2024
ee5a477
Add an extra "#" to commented-out emission diagnostics
yantosca Jul 31, 2024
dae4956
Edit CHANGELOG.md to mention that GCHP "alldiags" test were added
yantosca Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,32 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
### Added
- Added number of levels with clouds for photolysis to geoschem_config.yml and Input_Opt to pass to Cloud-J
- Added `State_Grid%CPU_Subdomain_ID` and `State_Grid%CPU_Subdomain_FirstID` as "identifier numbers" for multiple instances of GEOS-Chem on one core in WRF and CESM
- Added simulation with all diagnostics on in HISTORY.rc to integration tests for GCClassic (including Planeflight + ObsPack) and GCHP
- Added descriptive error message in `Interfaces/GCHP/gchp_historyexportsmod.F90`

### Changed
- Now reset `State_Diag%SatDiagnCount` to zero in routine`History_Write` (instead of in `History_Netcdf_Write`)
- Update rundir creation scripts to turn off the MEGAN extension for "standard" fullchem simulations
- Updated emissions used in CESM to match standard emissions used in the 14.4 offline model
- Disable support For FAST-JX for all simulations except Hg
- Replace calls to `GEOS_CHEM_STOP` with calls to `GC_Error` in `planeflight_mod.F90`
- Script `test/integration/GCHP/integrationTestExecute.sh` now resets `cap_restart` time to `000000`, to facilitate manual restart

### Fixed
- Typo in `setCommonRunSettings.sh` that made GCHP always choose mass fluxes for meteorology
- Fixed bug in # levels with cloud used in photolysis when using GCAP met or CESM
- Fixed typos for `SatDiagnEdge` collection in `HISTORY.rc` templates
- The `SatDiagnOH` diagnostic now works for the carbon simulation
- Restored missing fields for `UVFlux` collection in `run/GCClassic/HISTORY.rc.templates/HISTORY.rc.fullchem`
- Comment out `UVFlux` diagnostic in the "alldiags" integration test, there is a floating point error. Look at this later.
- Now use SO4 instead of O3 in the GCHP fullchem budget diagnostic (SO4 is soluble, O3 is not)
- Convert `UVFlux_Tag_Names` to uppercase in the comparison in `Get_UVFlux_Bin`(located in`Headers/state_diag_mod.F90`)
- Fixed typo (missing `_` character) in GCHP `DryDep` collection diagnostic entries
- Commented out with `###` emissions diagnostics in the GCHP `HISTORY.rc.fullchem` template that are not present in the corresponding `HEMCO_DIAGN.rc` template

### Removed
- Entry `SatDiagnPEDGE` from the `SatDiagn` collection; This needs to go into the `SatDiagnEdge` collection.


### Changed
- Only read photolysis data in `Init_Photolysis` in first instance of GEOS-Chem on each PET in CESM as PIO requires it

Expand Down
Loading