KPP Standalone from Obin Sturm #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
added
category: Feature Request
yantosca
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Thanks @lizziel for prepping this PR. I have some changes:
- Remove the
.exefile from the repo, we shouldn't track binaries. - I would prefer to see all of the standalone files go into a
KPP/standalonefolder. This would make it easier to also create standalone simulations for the other mechanisms if so desired.
yantosca
reviewed
Sep 27, 2024
yantosca
added
the
topic: Chemical Mechanisms
lizziel
changed the base branch from
dev/14.5.0
to
dev/no-diff-to-benchmark
yantosca
force-pushed
the
feature/kpp_standalone
branch
from
4a411b1 to
edcafd0
Compare
obin1
reviewed
Oct 10, 2024
yantosca
force-pushed
the
feature/kpp_standalone
branch
from
d801186 to
38162aa
Compare
yantosca
force-pushed
the
feature/kpp_standalone
branch
from
38162aa to
edcafd0
Compare
KPP/standalone - Folder which contains source code from the GitHub repository: https://github.com/geoschem/KPP-Standalone. This is a fork of the https://github.com/KineticPreProcessor/KPP-Standalone repo by Obin Sturm, Mike Long, and Christoph Keller. The branch geoschem-dev is checked out. This is where we can place GEOS-Chem-specific updates without touching the original code in the kpp-standalone branch. branch is set to geoschem-dev, which is the branch to be used for interfacing into the GEOS-Chem model .gitmodules - This was updated by running the command: git submodule add -b geoschem-dev \ https://github.com/geoschem/KPP-Standalone \ KPP/standalone CHANGELOG.md - Updated accordingly KPP/fullchem/Makefile KPP/fullchem/kpp_standalone*.F90 KPP/fullchem/samples_kpp_standalone/* - Removed from the KPP/fullchem folder. KPP/standalone - Folder containing code from https://github.com/geoschem/KPP-Standalone Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
KPP/CMakeLists.txt - Add calls to "add_directory(standalone)" in the fullchem and custom "if" blocks. This will tell CMake to look for the CMakeLists.txt file in the KPP/standalone folder, and to build the standalone files (libKppStandalone.a) after libKPP.a has been built. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This merge brings PR #2483 (KPP standalone from Obin Sturm, by @obin1 and @lizziel) into the GEOS-Chem 14.6.0 development stream. This PR does the following: 1. Adds submodule https://github.com/geoschem/KPP-Standalone in the KPP/standalone folder 2. Updates KPP/CMakeListst.txt to build the KPP standalone executable when the GEOS-Chem executable is built (currently only for fullchem or custom mechanisms) Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
|
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
CodeDir : b4cea44 GEOS-Chem update: Merge PR #2482 (KPP standalone interface)
GEOS-Chem : 860b90cdd Merge PR #2483 (KPP standalone from Obin Sturm)
HEMCO : deaa192 HEMCO 3.10.0 release
Cloud-J : f8a2b7f Update version number for 8.0.1 release
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Using 24 OpenMP threads
Number of execution tests: 30
Submitted as SLURM job: 59046109
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
yantosca
approved these changes
Nov 21, 2024
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
CodeDir : a7ab3eb GEOS-Chem update: Merge PR #2482 (KPP standalone interface)
MAPL : 9ad63ae Merge PR #37 containing update to vertically flip imports with dimensionless pressure proxy lev coordinates
GMAO_Shared : 4ddb3ec Merge pull request #2 from geoschem/feature/mapl-upgrade
ESMA_cmake : ad5deba Added ecbuild as a submodule of ESMA_cmake
gFTL-shared : 4b82492 Merge branch 'upstream_v1.5.0' into feature/v1.5.0
FMS : 259759d Merge pull request #3 from geoschem/feature/update_gmao_libs
FVdycoreCubed : af42462 Merge PR #8 (Add PLEadv diagnostic for offline advection in GCHP)
geos-chem : 860b90cdd Merge PR #2483 (KPP standalone from Obin Sturm)
HEMCO : deaa192 HEMCO 3.10.0 release
yaFyaml : 19afe50 Merge branch 'upstream_v1.0.4' into feature/v1.0.4
pFlogger : 2c4b724 Merge branch 'upstream_v1.9.1' into feature/v1.9.1
Cloud-J : f8a2b7f Update version number for 8.0.1 release
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Number of execution tests: 12
Submitted as SLURM job: 59046957
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
yantosca
approved these changes
Nov 21, 2024
obin1
approved these changes
Nov 21, 2024
yantosca
changed the base branch from
dev/no-diff-to-benchmark
to
dev/14.6.0
yantosca
added a commit
that referenced
this pull request
Nov 22, 2024
This merge brings PR #2483 (KPP standalone from Obin Sturm, by @obin1 and @lizziel) into the GEOS-Chem 14.5.1 development stream. This PR does the following: 1. Adds submodule https://github.com/geoschem/KPP-Standalone in the KPP/standalone folder 2. Updates KPP/CMakeListst.txt to build the KPP standalone executable when the GEOS-Chem executable is built (currently only for fullchem or custom mechanisms) Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
This was referenced Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This draft PR contains updates for KPP Standalone from Obin Sturm (GMAO) contained in GEOS-ESM#19. That original PR is built off of branch geos/develop in the GEOS-Chem fork in GMAO's GitHub. That version is not mergable into the standard model so this PR will be used instead.
Tagging @obin1, @yantosca
Expected changes
See GEOS-ESM#19
Reference(s)
https://github.com/KineticPreProcessor/KPP-Standalone/tree/kpp-standalone
Related Github Issue
GEOS-ESM#19
Please link to the corresponding Github issue(s) here. If fixing a bug, there should be an issue describing it with steps to reproduce.