Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CEDS TMB emissions #2507

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Conversation

kelvinhb
Copy link
Contributor

@kelvinhb kelvinhb commented Oct 9, 2024

Name and Institution (Required)

Name: Kelvin Bates
Institution: CU Boulder

Describe the update

Changed the CEDS TMB emission fields to actually emit TMB like they're supposed to, instead of emitting HCOOH. I'm not sure if this fix needs to go into any other HEMCO_Config.rc template files, either in run/GCClassic or in other run/ directories, but hopefully we can make any other necessary changes down the line. Currently the only change is to HEMCO_Config.rc.fullchem.

Expected changes

Emissions of HCOOH will decrease (specifically anthropogenic emissions from the CEDS inventory), and those of TMB will increase. This should have minimal knock-on effects to oxidants.

Reference(s)

N/A

Related Github Issue

N/A

Changed the CEDS TMB emission fields to actually emit TMB like they're supposed to, instead of emitting HCOOH. I'm not sure if this fix needs to go into any other HEMCO_Config.rc template files, either in run/GCClassic or in other run/ directories, but hopefully we can make any other necessary changes down the line
@yantosca yantosca self-assigned this Oct 9, 2024
@yantosca yantosca added topic: Configuration Files Related to GEOS-Chem configuration files category: Bug Fix Fixes a previously-reported bug topic: Emissions Related to emissions inventories used in GEOS-Chem labels Oct 9, 2024
@yantosca yantosca added this to the 14.6.0 milestone Oct 9, 2024
@yantosca yantosca added the Topic: Fullchem Simulations Related to full-chemistry simulations label Oct 10, 2024
@yantosca yantosca self-requested a review October 10, 2024 20:57
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @kelvinhb, it looks good. A couple of things:

  1. We'd also need to make the same change in run/GCHP/HEMCO_Config.rc.templates/HEMCO_Config.rc.fullchem
  2. Would you be able to update the CHANGELOG.md file? You can add a one-liner note under Unreleased -> Fixed saying "Fixed CEDS HEMCO_Config.rc entries to emit TMB into the TMB species (and not HCOOH)". We now require CHANGELOG.md updates for each PR.

Thanks!

Changed the CEDS TMB emission fields to actually emit TMB like they're supposed to, instead of emitting HCOOH.
Changed the CEDS TMB emission fields to actually emit TMB like they're supposed to, instead of emitting HCOOH.
@kelvinhb
Copy link
Contributor Author

Hi @yantosca -- I think I've made these changes as needed, let me know if there's anything else that needs doing!

@yantosca yantosca changed the base branch from dev/14.5.0 to main November 8, 2024 17:25
@yantosca yantosca self-requested a review November 19, 2024 21:07
@yantosca yantosca changed the base branch from main to dev/14.6.0 November 19, 2024 21:08
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kelvinhb! These changes look good to merge.

@yantosca
Copy link
Contributor

@kelvinhb: Is it OK if I push merge conflict resolutions back to your kelvinhb:Fix-CEDS-TMB-emissions branch? This will make the updates show up on the PR. It will also bring in updates from the 14.5.0 release, so if you don't want that, let me know.

This merge brings PR geoschem#2507 (Fix CEDS TMB emissions, by @kelvinhb)
into the GEOS-Chem 14.6.0 development stream.

This PR fixes errors in the HEMCO_Config.rc.fullchem template files
(for GCClassic and GCHP) pertaining to TMB emissions from the
CEDS global inventory.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@kelvinhb
Copy link
Contributor Author

I think that should be fine... does it need any action on my end?

CHANGELOG.md
- Move the entry pertaining to PR geoschem#2507 (CEDS TMB emissions) out
  of the 14.5.0 section and into the Unreleased section

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca
Copy link
Contributor

@kelvinhb: No action on your end needed. As long as you are not actively using the branch that'll be OK.

@yantosca
Copy link
Contributor

All GEOS-Chem Classic integration tests passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

CodeDir   : cc01a47 GCClassic 14.5.0 release
GEOS-Chem : a1b784fd7 PR #2507 post-merge fixes: Update CHANGELOG.md
HEMCO     : deaa192 HEMCO 3.10.0 release
Cloud-J   : f8a2b7f Update version number for 8.0.1 release
HETP      : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables

Using 24 OpenMP threads
Number of execution tests: 30

Submitted as SLURM job: 58707404
==============================================================================
 
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

All GCHP execution tests also passed:

==============================================================================
GCHP: Execution Test Results

CodeDir       : a9e7c3f GCHP 14.5.0 release
MAPL          : 9ad63ae Merge PR #37 containing update to vertically flip imports with dimensionless pressure proxy lev coordinates
GMAO_Shared   : 4ddb3ec Merge pull request #2 from geoschem/feature/mapl-upgrade
ESMA_cmake    : ad5deba Added ecbuild as a submodule of ESMA_cmake
gFTL-shared   : 4b82492 Merge branch 'upstream_v1.5.0' into feature/v1.5.0
FMS           : 259759d Merge pull request #3 from geoschem/feature/update_gmao_libs
FVdycoreCubed : af42462 Merge PR #8 (Add PLEadv diagnostic for offline advection in GCHP)
geos-chem     : a1b784fd7 PR #2507 post-merge fixes: Update CHANGELOG.md
HEMCO         : deaa192 HEMCO 3.10.0 release
yaFyaml       : 19afe50 Merge branch 'upstream_v1.0.4' into feature/v1.0.4
pFlogger      : 2c4b724 Merge branch 'upstream_v1.9.1' into feature/v1.9.1
Cloud-J       : f8a2b7f Update version number for 8.0.1 release
HETP          : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables

Number of execution tests: 12

Submitted as SLURM job: 58708357
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a previously-reported bug topic: Configuration Files Related to GEOS-Chem configuration files topic: Emissions Related to emissions inventories used in GEOS-Chem Topic: Fullchem Simulations Related to full-chemistry simulations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants