Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for GEOS-only code in 14.5 #2553

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Nov 4, 2024

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR contains fixes in GEOS-only code blocks to work with GEOS-Chem 14.5. All fixes are related to changes in species unit conversions and are need to successfully build GEOS with GEOS-Chem 14.5.

Expected changes

This is a zero diff update.

Reference(s)

None

Related Github Issue

None

@lizziel lizziel changed the base branch from main to dev/no-diff-to-benchmark November 4, 2024 15:32
@lizziel lizziel added no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: GEOS ESM Related to running GEOS-Chem in the GEOS ESM labels Nov 4, 2024
@lizziel lizziel added this to the 14.5.1 milestone Nov 4, 2024
@lizziel lizziel changed the title Fixes for GEOS-only code compatibility with 14.5 Updates for GEOS-only code in 14.5 Nov 4, 2024
@lizziel lizziel self-assigned this Nov 22, 2024
@lizziel lizziel marked this pull request as ready for review December 5, 2024 15:53
@yantosca yantosca self-requested a review December 5, 2024 15:56
@yantosca yantosca added the category: Interface to External Model Related to GEOS-Chem updates needed to interface with other models label Dec 5, 2024
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizziel. Good to merge, as these are updating the unit conversions in #ifdef MODEL_GEOS blocks.

Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog conflict resolution approved!

@lizziel lizziel merged commit be335b7 into dev/no-diff-to-benchmark Dec 5, 2024
@msulprizio msulprizio deleted the bugfix/geos branch December 6, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Interface to External Model Related to GEOS-Chem updates needed to interface with other models no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: GEOS ESM Related to running GEOS-Chem in the GEOS ESM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants