Fix bug in GCHP integration test creation due to duplicate "Created " entries in log #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding this broke GCHP integration tests due to a duplicate output line containing "Create " which was used to get run directory name. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
added
topic: Benchmarking and Testing
msulprizio
approved these changes
Dec 6, 2024
msulprizio
deleted the
bugfix/gchp_integration_test_issue_from_rundir_creation_message_change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This update removes a line added in a previous dev commit which showed run directory name at the end of GCHP run directory creation. The additional broke integration tests because there were then two lines in the log output containing "Created ". Two lines were then concatenated to get run directory name, which was incorrect.
No changelog updated is needed because this bug is not in an official release.
Expected changes
This is a no diff update.
Reference(s)
None
Related Github Issue
None