Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to GCClassic HISTORY.rc template files advising users not to change BoundaryConditions.frequency #2670

Merged

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Jan 3, 2025

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Describe the update

Following upon the issue reported by @LittleFeify in #2665, we have now added comments to the BoundaryConditions collection in all GEOS-Chem Classic HISTORY.rc template files advising users not to change the BoundaryConditions.frequency setting. The frequency must be left at 00000000 030000, as GEOS-Chem Classic nested-grid simulations expect to read boundary conditions every 3 hours.

Expected changes

This is a no-diff-to-benchmark update. The only changes that were made were comments in the run/GCClassic/HISTORY.rc.templates/HISTORY.rc.* files.

Related Github Issue

Notes

Ideally this can go into 14.5.1, but if it is not possible, it can go into the next Y or Z version.

run/GCClassic/HISTORY.rc.templates/HISTORY.rc.*
- Add a comment to the BoundaryConditions collection header warning
  users not to change the BoundaryConditions.frequency setting.  This
  must be left at "00000000 030000", as GEOS-Chem Classic nested-grid
  simulations expect to read boundary conditions every 3 hours.

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added topic: Configuration Files Related to GEOS-Chem configuration files no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations category: Bug Fix Fixes a previously-reported bug labels Jan 3, 2025
@yantosca yantosca requested a review from msulprizio January 3, 2025 21:56
@yantosca yantosca self-assigned this Jan 3, 2025
@yantosca yantosca added this to the 14.5.1 milestone Jan 6, 2025
Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR simply adds comments to HISTORY.rc files. Good to merge.

Copy link
Contributor Author

yantosca commented Jan 7, 2025

Thanks @msulprizio!

@yantosca yantosca merged commit 3de2b85 into dev/no-diff-to-benchmark Jan 7, 2025
@yantosca yantosca deleted the feature/warn-users-not-to-change-bc-freq branch January 7, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a previously-reported bug no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Configuration Files Related to GEOS-Chem configuration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants