Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default environment files for integration tests on Harvard Cannon from gnu10 to gnu12 #2674

Merged

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Jan 8, 2025

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Describe the update

This PR changes the run/shared/commonFunctionsForTests.sh script as follows:

  1. Environment file run/GCClassic/runScriptSamples/operational_examples/harvard_cannon/gcclassic.gcc12_cannon_rocky.env will be used for GEOS-Chem Classic integration tests on Harvard Cannon (unless otherwise specified)

  2. Environment file run/GCHP/runScriptSamples/operational_examples/harvard_cannon/gchp.gcc12_openmpi4_cannon_rocky.env will be used for GCHP integration tests on Harvard Cannon (unless otherwise specified)

Expected changes

This is a no-diff-to-benchmark update. It only changes the compiler (plus corresponding modules) from GCC 10.2.0 to GCC 12.2.0 for integration tests on Harvard Cannon. This is because most Harvard Cannon developers are using the GCC 12.2.0 compilers now.

Related Github Issue

N/A

test/shared/commonFunctionsForTests.sh
- In function get_default_gcc_env_file, now use environment file
  gcclassic.gcc12_cannon_rocky.env
- In function get_default_gchp_env_file, now use environment file
  gchp.gcc12_openmpi4_cannon_rocky.env


CHANGELOG.md
- Updated accordingly


Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added topic: Benchmarking and Testing Related to CI, integration tests, or scientific benchmarking no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations category: Bug Fix Fixes a previously-reported bug labels Jan 8, 2025
@yantosca yantosca added this to the 14.5.1 milestone Jan 8, 2025
@yantosca yantosca requested a review from msulprizio January 8, 2025 18:48
@yantosca yantosca self-assigned this Jan 8, 2025
@yantosca
Copy link
Contributor Author

yantosca commented Jan 9, 2025

All GEOS-Chem Classic integration tests passed;

==============================================================================
GEOS-Chem Classic: Execution Test Results

CodeDir   : 9428533 GEOS-Chem update: Merge PR #2554 (bug fixes for carbon simulations)
GEOS-Chem : ab77f5279 Merge PR #2674 (Harvard Cannon int test now use GNU12 compilers)
HEMCO     : b94f2e0 Merge pull request #300 from geoschem/bugfix/run_with_geos
Cloud-J   : f8a2b7f Update version number for 8.0.1 release
HETP      : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables

Using 24 OpenMP threads
Number of execution tests: 30

Submitted as SLURM job: 65895727
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also, all difference tests were identical to gcc.13.942853 except for:

  • TOMAS (parallelization?)
  • APM (parallelization?)
  • fullchem_alldiags (diagnostic differences in KppDiags, ObsPack only)

@yantosca
Copy link
Contributor Author

yantosca commented Jan 9, 2025

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

CodeDir       : 7fe7228 GEOS-Chem update: Merge PR #2554 (bug fixes for carbon simulations)
MAPL          : 9ad63ae Merge PR #37 containing update to vertically flip imports with dimensionless pressure proxy lev coordinates
GMAO_Shared   : 4ddb3ec Merge pull request #2 from geoschem/feature/mapl-upgrade
ESMA_cmake    : ad5deba Added ecbuild as a submodule of ESMA_cmake
gFTL-shared   : 4b82492 Merge branch 'upstream_v1.5.0' into feature/v1.5.0
FMS           : 259759d Merge pull request #3 from geoschem/feature/update_gmao_libs
FVdycoreCubed : af42462 Merge PR #8 (Add PLEadv diagnostic for offline advection in GCHP)
geos-chem     : ab77f5279 Merge PR #2674 (Harvard Cannon int test now use GNU12 compilers)
HEMCO         : b94f2e0 Merge pull request #300 from geoschem/bugfix/run_with_geos
yaFyaml       : 19afe50 Merge branch 'upstream_v1.0.4' into feature/v1.0.4
pFlogger      : 2c4b724 Merge branch 'upstream_v1.9.1' into feature/v1.9.1
Cloud-J       : f8a2b7f Update version number for 8.0.1 release
HETP          : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables

Number of execution tests: 12

Submitted as SLURM job: 65895735
==============================================================================

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Minor differences were observed across the board w/r/t gchp.13.7fe722, because that set of tests used GCC 10.2.0 compilers and this set of tests used GCC 12.2.0 compilers. Differences are at the level of numerical noise.

@yantosca yantosca merged commit ab77f52 into dev/no-diff-to-benchmark Jan 9, 2025
@yantosca yantosca deleted the bugfix/harvard-gcc12-in-int-tests branch January 9, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a previously-reported bug no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Benchmarking and Testing Related to CI, integration tests, or scientific benchmarking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants