[PULL REQUEST] Merge GEOS-Chem 13.0.2 into the 13.1.0 development branch #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit (and also commit geoschem/HEMCO 2e4df52) addresses a problem that arose in GEOS-Chem 13.0.1. In that version, the time cycle flag "EFY" was changed to "exact, force error if not found, use simulation year, read only once". This was done in order to make sure that the restart file date matched the user's simulation start date; otherwise an error is thrown. However, the met field entries in HEMCO_Config.rc also used this EFY time cycle flag. As a result, the modification of behavior to EFY meant that met fields were no longer being read from disk as the situation evolved. To fix this situation, we have created a new HEMCO time cycle flag, called "EFYK". This is similar to "EFY", but will cause the data to be continuously read during a simulation. In this commit we have updated the HEMCO_Config.rc entries in the run/GCClassic and run/GCHP directories accordingly. (NOTE: This will only affect GCClassic runs as GCHP uses MAPL to read data. But we have added EFYK flags to GCHP HEMCO_Config.rc templates for consistency.) Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
We have restored the previous functionality of HEMCO time cycle flag EFY (exact, forced error if not found, use sim year) for the met fields. We now use flag EFYO (same as EFY, but read only once) for the restart file. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
We now use time cycle flag EFYO (exact, force error if not found, use simulation year, read only once) for restart files. However, the default restart files for certain specialty simulations might not contain all species. Therefore, for these specialty simulations, we change the time cycle flag EFYO -> EY in HEMCO_Config.rc during run directory generation. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
category: Bug
msulprizio
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the fixes contained in GEOS-Chem 13.0.2 into the 13.1.0 development branch (contained in "dev"). This fixes the issue reported in #686, namely, that GEOS-Chem "Classic" met fields were only being read at the first timestep of a simulation and not thereafter.