Fixes #1167: OL3 GoogleLayer reset on map change

geosolutions-it · Nov 3, 2016 · 67fafc1 · 67fafc1
1 parent 8e628c8
commit 67fafc1
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/web/client/components/map/openlayers/Layer.jsx b/web/client/components/map/openlayers/Layer.jsx
@@ -61,6 +61,7 @@ const OpenlayersLayer = React.createClass({
                 this.props.map.removeLayer(this.layer);
             }
         }
+        Layers.removeLayer(this.props.type, this.props.options, this.props.map, this.props.mapId, this.layer);
     },
     render() {
         if (this.props.children) {

diff --git a/web/client/components/map/openlayers/plugins/GoogleLayer.js b/web/client/components/map/openlayers/plugins/GoogleLayer.js
@@ -193,6 +193,11 @@ Layers.registerType('google', {
             gmaps[mapId].setCenter(new google.maps.LatLng(center[1], center[0]));
             gmaps[mapId].setZoom(view.getZoom());
         }
+    },
+    remove(options, map, mapId) {
+        if (rendererItem === options.name) {
+            rendererItem = undefined;
+            delete gmaps[mapId];
+        }
     }
-
 });
diff --git a/web/client/utils/openlayers/Layers.js b/web/client/utils/openlayers/Layers.js
@@ -45,6 +45,13 @@ var Layers = {
             }
         }
     },
+    removeLayer: function(type, options, map, mapId, layer) {
+        var layerCreator = layerTypes[type];
+        if (layerCreator && layerCreator.remove) {
+            return layerCreator.remove(options, map, mapId, layer);
+        }
+        return null;
+    },
     renderLayer: function(type, options, map, mapId, layer) {
         var layerCreator = layerTypes[type];
         if (layerCreator && layerCreator.render) {