Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is not possible to add decimals in the aeronautical form #10663

Closed
1 task done
MV88 opened this issue Nov 11, 2024 · 2 comments · Fixed by #10668 or #10678
Closed
1 task done

Is not possible to add decimals in the aeronautical form #10663

MV88 opened this issue Nov 11, 2024 · 2 comments · Fixed by #10668 or #10678
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted bug C125-AUSTROCONTROL-2024-MapStore investigation
Milestone
2024.02.02

Comments

@MV88
Copy link
Contributor

MV88 commented Nov 11, 2024 •
edited by tdipisa
Loading

Description

It is not possible to enter centesimal number 04 after the comma/dot

like 0.04

this bug was introduced here https://github.com/geosolutions-it/MapStore2/tree/ddf127e98663f55d02253496d7e4cba09c5f0416
provided for #10289

How to reproduce

  • open map viewer
  • open search by coordinate
  • switch to aeronautical
  • try enter the decimal part as 04

Expected Result

to enter it
Current Result

it resets to integer as soon one enters the first 0 and it removes the decimal separator too

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@tdipisa tdipisa assigned dsuren1 and tdipisa and unassigned tdipisa and dsuren1 Nov 11, 2024
@tdipisa tdipisa added this to the 2024.02.02 milestone Nov 11, 2024
@tdipisa tdipisa assigned mahmoudadel54 and unassigned tdipisa Nov 11, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 12, 2024
@mahmoudadel54
geosolutions-it#10663: fix adding decimals in the aeronautical form
1008018 
Description:
- handle fixing the issue of prevent enters centesimal number after the comma/dot in aeronautical form and decimal form as well
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 12, 2024
@mahmoudadel54
geosolutions-it#10663: fix adding decimals in the aeronautical form
58e7e6c 
Description:
- add helpful comment
@mahmoudadel54 mahmoudadel54 mentioned this issue Nov 12, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Nov 12, 2024 that will close this issue
#10663: fix adding decimals in the aeronautical form in searcg by coordinates #10668
Merged
12 tasks
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 12, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 12, 2024
@mahmoudadel54
geosolutions-it#10663: edit unit test in IntlNumberFormatControl-test…
462b679 
….jsx to fix FE failure
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 12, 2024
@mahmoudadel54
geosolutions-it#10663: revert unnecessary change
1146269
@MV88 MV88 closed this as completed in 2f4f909 Nov 13, 2024
@MV88
Copy link
Contributor Author

MV88 commented Nov 13, 2024

@ElenaGallo please test it in DEV

@tdipisa
Copy link
Member

tdipisa commented Nov 13, 2024 •
edited
Loading

@ElenaGallo please test it in DEV

@ElenaGallo please keep an eye on connected #10289 (see description) to improve its functional test including also this issue case.

@ElenaGallo ElenaGallo self-assigned this Nov 14, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 14, 2024
@mahmoudadel54
Fix geosolutions-it#10663: adding decimals in the aeronautical form i…
6b33eda 
…n searcg by coordinates (geosolutions-it#10668)

* geosolutions-it#10663: fix adding decimals in the aeronautical form
Description:
- handle fixing the issue of prevent enters centesimal number after the comma/dot in aeronautical form and decimal form as well

* geosolutions-it#10663: fix adding decimals in the aeronautical form
Description:
- add helpful comment

* geosolutions-it#10663: edit unit test in IntlNumberFormatControl-test.jsx to fix FE failure

* geosolutions-it#10663: revert unnecessary change
@mahmoudadel54 mahmoudadel54 mentioned this issue Nov 14, 2024
Merged
@mahmoudadel54 mahmoudadel54 linked a pull request Nov 14, 2024 that will close this issue
[Backport 2024.02.xx] Fix #10663: adding decimals in the aeronautical form in searcg by coordinates (#10668) #10678
Merged
tdipisa pushed a commit that referenced this issue Nov 14, 2024
@mahmoudadel54
Fix #10663: adding decimals in the aeronautical form in searcg by coo…
b8a8c7c 
…rdinates (#10668) (#10678)

* #10663: fix adding decimals in the aeronautical form
Description:
- handle fixing the issue of prevent enters centesimal number after the comma/dot in aeronautical form and decimal form as well

* #10663: fix adding decimals in the aeronautical form
Description:
- add helpful comment

* #10663: edit unit test in IntlNumberFormatControl-test.jsx to fix FE failure

* #10663: revert unnecessary change
@tdipisa tdipisa added Accepted and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
Accepted bug C125-AUSTROCONTROL-2024-MapStore investigation
Projects
None yet
Milestone
2024.02.02
5 participants
@tdipisa @MV88 @dsuren1 @ElenaGallo @mahmoudadel54