Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openlayers Snapshot do not work with OpenTopoMap background #1269

Closed
offtherailz opened this issue Nov 14, 2016 · 1 comment
Closed

Openlayers Snapshot do not work with OpenTopoMap background #1269

offtherailz opened this issue Nov 14, 2016 · 1 comment
Labels
Accepted bug OpenLayers Priority: Medium

Comments

@offtherailz
Copy link
Member

The OpenTopoMap tiles do not have the CORS headers, as the other common tile provider have, than the resulting canvas will be tainted, and then not exportable.
image

We should:

  1. provide an error to the user for this kind of issue
  2. Investigate on the tileproviders we support to identify which of them have the same problem
  3. Implement proxy usage for this kind of layers, as we do for WMS. (see : https://github.com/geosolutions-it/MapStore2/blob/master/web/client/components/map/openlayers/snapshot/GrabMap.jsx#L50)
offtherailz added a commit to offtherailz/MapStore2 that referenced this issue Nov 15, 2016
@offtherailz
Improvements to the Snapshot Tool
d16dc95 
 - Fix geosolutions-it#1267. Now if the canvas is tainted, a warning suggest the user how to have a better result
 - Removed glitch when leaflet try to save snapshot (a box was appearing in top-right corner)
 - Simplified the snapshot creation procedure (triggers)
 - Error management in case of tainted canvas in the save mode (see geosolutions-it#1269)
 - Various Fixes with wrong sizes of snapshot
 - Now leaflet snapshot support resized map when the drawer menu do not overlap
 - Increased test coverage
@offtherailz offtherailz mentioned this issue Nov 15, 2016
Merged
offtherailz added a commit that referenced this issue Nov 15, 2016
@offtherailz
Improvements to the Snapshot Tool (#1272)
51cb7b2 
- Fix #1267. Now if the canvas is tainted, a warning suggest the user how to have a better result
 - Removed glitch when leaflet try to save snapshot (a box was appearing in top-right corner)
 - Simplified the snapshot creation procedure (triggers)
 - Error management in case of tainted canvas in the save mode (see #1269)
 - Various Fixes with wrong sizes of snapshot
 - Now leaflet snapshot support resized map when the drawer menu do not overlap
 - Increased test coverage
@tdipisa
Copy link
Member

tdipisa commented Jul 27, 2018

The Snapshot tool has been removed from MS2. Closed for inactivity.

@tdipisa tdipisa closed this as completed Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted bug OpenLayers Priority: Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@offtherailz @tdipisa @chiaracurcio