Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display the current MS2 version in the UI #1302

Closed
Gnafu opened this issue Nov 28, 2016 · 5 comments
Closed

Display the current MS2 version in the UI #1302

Gnafu opened this issue Nov 28, 2016 · 5 comments
Assignees
@mbarto
Labels
enhancement Priority: Medium
Milestone
2017.03.01 (Harde...

Comments

@Gnafu
Copy link
Contributor

Gnafu commented Nov 28, 2016 •
edited
Loading

Users have no way to tell what version of MapStore2 they are using.
Having a version displayed somewhere in the UI (even if hidden under menus, windows, tabs, or anything) is usefull when reporting a bug.
@offtherailz
Copy link
Member

See this as an example:
https://github.com/redux-observable/redux-observable/blob/master/scripts/preprepublish.sh

@offtherailz offtherailz self-assigned this May 2, 2017
@mbarto mbarto assigned mbarto and unassigned offtherailz May 11, 2017
@mbarto
Copy link
Contributor

mbarto commented May 11, 2017

image

@Gnafu
Copy link
Contributor Author

Gnafu commented May 11, 2017

I'll keep just "Version"

@mbarto
Copy link
Contributor

mbarto commented May 12, 2017

Should work like this:

  • you can specify a parameter to maven with the version: (e.g. -Dmapstore2.version=2017.00.04)
  • you can also give a parameter to build.sh (e.g. build.sh 2017.00.04
  • we can add a BUILD param to jenkins jobs so that this is passed to build.sh during the build

@Gnafu
Copy link
Contributor Author

Gnafu commented May 12, 2017

The same mechanism will be usefull to pass Google/Bing/MapBox/other API keys

mbarto added a commit to mbarto/MapStore2 that referenced this issue May 12, 2017
@mbarto
Fixes geosolutions-it#1302: current version in the UI
1dd3ac6
@MV88 MV88 closed this as completed in 7183c93 May 12, 2017
@ghost ghost removed the pending review label May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbarto mbarto

Labels
enhancement Priority: Medium
Projects
None yet
Milestone
2017.03.01 (Hardening & Fixes & Cesium)
Development

No branches or pull requests
4 participants
@simboss @offtherailz @mbarto @Gnafu