-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override properties used in connect methods from configuration #1645
Labels
Comments
MV88
changed the title
Allow to override properties used in connect methods
Override properties used in connect methods from configration
Mar 27, 2017
MV88
changed the title
Override properties used in connect methods from configration
Override properties used in connect methods from configuration
Mar 27, 2017
We could set the initialState in componentWillMount or use something like "initialActions" to run on Plugins add to initialize the state (only once). |
I would avoid using lifecycle methods. My idea:
I am going to prepare a PR for this |
👍 |
mbarto
added a commit
to mbarto/MapStore2
that referenced
this issue
Mar 28, 2017
…nition; properties in pluginCfg override state connected properties
ghost
removed
the
pending review
label
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It is known that the properties used in connect method are not overridable from the config.
This can be achieved with some workaround ( set them in componentWillMount) but this is bad practice.
The text was updated successfully, but these errors were encountered: