Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace agGrid with react-data-grid #1812

Closed
offtherailz opened this issue May 11, 2017 · 0 comments · Fixed by #2064
Closed

replace agGrid with react-data-grid #1812

offtherailz opened this issue May 11, 2017 · 0 comments · Fixed by #2064
Assignees
@offtherailz @MV88
Labels
C040-2020-COMUNE_GE-SUPPORT Priority: Blocker
Milestone
2017.04.00 (Editing)

Comments

@offtherailz
Copy link
Member

offtherailz commented May 11, 2017 •
edited
Loading

agGrid is going to not be usable anymore because:

  • Next version have strict license
  • The implementation in react is related to the angular one, so following the 1 direction data flow is a nightmare
  • during this year some alternatives are available.

We should use react-data-grid
pros:

  • it has all the functionalities we are using in agGrid
  • supports some pluggable editors + attribute filtering included.

cons:

  • should externalize the pagination functionalities.
  • infinite scroll is not built in but should be easy to implement it as pagination, see issue 94 of react-data-grid:
@offtherailz offtherailz added this to the 2017.04.00 (Editing) milestone May 11, 2017
@simboss simboss mentioned this issue May 11, 2017
Closed
4 tasks
@offtherailz offtherailz self-assigned this May 12, 2017
@MV88 MV88 self-assigned this May 12, 2017
@offtherailz offtherailz mentioned this issue Jul 27, 2017
Merged
offtherailz added a commit that referenced this issue Jul 31, 2017
@offtherailz
Implemented Feature Editor Plugin (#2064)
a981157 
* Extended DrawSupport to edit existing Geometries (leaflet and OpenLayers). Fix #1819
* Replaces agGrid with react-data-grid (moved old to FeatureGrid_ag). Fix #1812
* Implementation of FeatureEditor plugin. Fix #1102 
* Added support for editing/drowing features. Fix #2038 
* Finalized support for WFST. Fix #1885

We should evaluate to:
 * Replace the hold grid example with the new grid
 * Hide unwanted tools in edit mode as in the [mockup](http://demo.geo-solutions.it/mockups/mapstore2/edit/000.html)

Other minor fixes: 
 * Opacity changes  does not refresh the whole layer now. Fix #2063
 * Now only a request is performed (2 only if a "wfs natural order missing primary key" error is detected). Fix #2043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@offtherailz offtherailz

@MV88 MV88

Labels
C040-2020-COMUNE_GE-SUPPORT Priority: Blocker
Projects
None yet
Milestone
2017.04.00 (Editing)
Development

Successfully merging a pull request may close this issue.

Implemented Feature Editor Plugin offtherailz/MapStore2
3 participants
@offtherailz @mbarto @MV88