Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If timeline expanded before data loaded, timeline is not rendered #3345

Closed
offtherailz opened this issue Nov 19, 2018 · 0 comments
Closed

If timeline expanded before data loaded, timeline is not rendered #3345

offtherailz opened this issue Nov 19, 2018 · 0 comments
Assignees
@baloola @chiaracurcio
Labels
Accepted bug geonode_integration Timeline
Milestone
2019.01.00

Comments

@offtherailz
Copy link
Member

offtherailz commented Nov 19, 2018 •
edited by baloola
Loading

when the user open a pre-saved map with timeline, if the user expanded the slider too early an empty timeline will be rendered to the screen. you have to collapse / expand the plugin to see the timeline data.
@offtherailz offtherailz added this to the 2018.03.00 milestone Nov 19, 2018
@offtherailz offtherailz changed the title Minor fixes and improvements to the timeline Fix the issue when the user expand the timeline before data has been loaded. Nov 19, 2018
@offtherailz offtherailz changed the title Fix the issue when the user expand the timeline before data has been loaded. Avoid the user to expand timeline until data is not loaded Nov 19, 2018
@offtherailz offtherailz removed their assignment Nov 19, 2018
@baloola baloola mentioned this issue Nov 19, 2018
Merged
6 tasks
offtherailz pushed a commit that referenced this issue Nov 19, 2018
@baloola @offtherailz
Fix #3345 fix issue when user expands timeline too early (#3349)
58610a6
@baloola baloola closed this as completed Nov 19, 2018
offtherailz added a commit that referenced this issue Nov 20, 2018
@offtherailz
Revert "Fix #3345 fix issue when user expands timeline too early (#3349…
47eab79 
…)"

This reverts commit 58610a6.
@offtherailz offtherailz reopened this Nov 20, 2018
offtherailz added a commit that referenced this issue Nov 20, 2018
@offtherailz
Fixed #3345. blank rendering with missing data
d93548d
@baloola baloola mentioned this issue Nov 29, 2018
Merged
6 tasks
@simboss simboss mentioned this issue Nov 30, 2018
Closed
6 tasks
offtherailz pushed a commit that referenced this issue Nov 30, 2018
@baloola @offtherailz
Fix #3345 fixing the initial component re-rendering (#3376)
4f293e0
@offtherailz offtherailz changed the title Avoid the user to expand timeline until data is not loaded If timeline expanded before data loaded, timeline is not rendered Nov 30, 2018
@ghost ghost removed the pending review label Nov 30, 2018
@chiaracurcio chiaracurcio self-assigned this Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baloola baloola

@chiaracurcio chiaracurcio

Labels
Accepted bug geonode_integration Timeline
Projects
None yet
Milestone
2019.01.00
Development

No branches or pull requests
3 participants
@offtherailz @baloola @chiaracurcio