Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve timeline's buttons #3397

Closed
offtherailz opened this issue Dec 6, 2018 · 2 comments · Fixed by #3470
Closed

Improve timeline's buttons #3397

offtherailz opened this issue Dec 6, 2018 · 2 comments · Fixed by #3470
Assignees
@allyoucanmap @chiaracurcio @gioscarda
Labels
Accepted geonode_integration Priority: Blocker Timeline
Milestone
2019.01.00

Comments

@offtherailz
Copy link
Member

offtherailz commented Dec 6, 2018 •
edited
Loading

Description

Current buttons bars do not fit the size of geonode's preview. In addition, the button to step forward and backward should always be visible.

Suggested solution:

  • Transform expand button in a small handle outside the timeline (suggested on top)
  • Remove playback button to collapse buttons
  • Always show all animation buttons, without any possibility to hide.
    scan_tl_simone
  • settings button should be separated from the animations button
@offtherailz offtherailz added this to the 2019.01.00 milestone Dec 6, 2018
@offtherailz offtherailz changed the title Rething a little the timeline's buttons Imporve timeline's buttons Dec 6, 2018
@offtherailz offtherailz changed the title Imporve timeline's buttons Improve timeline's buttons Dec 6, 2018
@allyoucanmap allyoucanmap mentioned this issue Dec 10, 2018
Merged
5 tasks
offtherailz pushed a commit that referenced this issue Dec 12, 2018
@allyoucanmap @offtherailz
Fix #3397 Updated timeline UI (#3402)
b5a6fa0
@allyoucanmap allyoucanmap mentioned this issue Dec 12, 2018
Merged
5 tasks
@tdipisa tdipisa closed this as completed Dec 18, 2018
@tdipisa tdipisa removed the review label Dec 18, 2018
@ghost ghost removed the pending review label Dec 18, 2018
@gioscarda gioscarda self-assigned this Dec 19, 2018
@gioscarda
Copy link
Contributor

The last requirement is not satisfied, the playback settings button is contiguous to the animations button. A little space between these two types of buttons is needed.

@simboss simboss mentioned this issue Jan 10, 2019
Closed
6 tasks
@tdipisa
Copy link
Member

tdipisa commented Jan 11, 2019 •
edited
Loading

@gioscarda @allyoucanmap the setting button position if fine now. What should be fixed now is the position of the settings panel:

time.png

@tdipisa tdipisa reopened this Jan 11, 2019
@tdipisa tdipisa added the ready label Jan 11, 2019
@allyoucanmap allyoucanmap mentioned this issue Jan 21, 2019
Merged
6 tasks
@ghost ghost removed the in progress label Jan 21, 2019
@gioscarda gioscarda self-assigned this Jan 22, 2019
@chiaracurcio chiaracurcio self-assigned this Jan 31, 2019
@allyoucanmap allyoucanmap mentioned this issue Feb 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allyoucanmap allyoucanmap

@chiaracurcio chiaracurcio

@gioscarda gioscarda

Labels
Accepted geonode_integration Priority: Blocker Timeline
Projects
None yet
Milestone
2019.01.00
Development

Successfully merging a pull request may close this issue.

Fix #3397 Improve timeline's buttons (Adjusted position of playback settings) allyoucanmap/MapStore2
5 participants
@offtherailz @tdipisa @allyoucanmap @chiaracurcio @gioscarda