Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Cesium viewer settings - MapSettings plugin #8106

Closed
3 tasks
allyoucanmap opened this issue Apr 14, 2022 · 0 comments
Closed
3 tasks

Include Cesium viewer settings - MapSettings plugin #8106

allyoucanmap opened this issue Apr 14, 2022 · 0 comments
Assignees
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted enhancement Internal New Feature used for new functionalities Priority: Medium
Milestone

Comments

@allyoucanmap
Copy link
Contributor

allyoucanmap commented Apr 14, 2022

Description

We should implement a plugin component called MapSettings that will be injected in the Settings plugins and should allow to configure some options related to the cesium map.

The expected options should be:

  • showSkyAtmosphere true/false
  • showGroundAtmosphere true/false
  • enableFog true/false
  • depthTestAgainstTerrain true/false

It would be nice also to include lighting options but this needs additional investigation because probably settings true/false is not enough (eg do we need to set also date time?). This options should be discussed before to develop it because we need to understand if it's feasible in this task or need a separate issue

  • enableLighting true/false

Acceptance criteria

  • if a user select an options in the settings it should be applied directly to the map
  • this options should be stored and added to the saved/exported map
  • this saved map options should be applied once the configuration is imported/loaded again

Other useful information

  • The Identify plugin has an example on how to inject a component inside the settings plugin (maybe we could avoid the array using fragments)

    Settings: {
    tool: [<FeatureInfoFormatSelector
    key="featureinfoformat"
    label={<Message msgId="infoFormatLbl" />
    } />, <FeatureInfoTriggerSelector
    key="featureinfotrigger" />],
    position: 3
    }

  • exported map contains a mapOptions key already but we should investigate on how it behaves compared with the other static mapOptions configuration in localConfig.json (eg it has priority, it split map options by library type, ...)

  • saveMapConfiguration is the function used to format the final saved map config

    mapOptions: currentMap.mapOptions || {}

  • The mapsave selector it could be useful to understand other function that compose the final saved map object

@allyoucanmap allyoucanmap added enhancement New Feature used for new functionalities 3D All issues related to the 3D rendering in CesiumJs labels Apr 14, 2022
@allyoucanmap allyoucanmap changed the title Include Cesium viewer settings Include Cesium viewer settings - MapSettings plugin May 6, 2022
@tdipisa tdipisa assigned weberjavi and unassigned tdipisa May 6, 2022
allyoucanmap pushed a commit that referenced this issue Jun 27, 2022
@ElenaGallo ElenaGallo self-assigned this Jul 7, 2022
@offtherailz offtherailz added this to the v2022.02.00 milestone Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted enhancement Internal New Feature used for new functionalities Priority: Medium
Projects
None yet
Development

No branches or pull requests

5 participants