Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapStore - Identify plugin - parametrize the maxItems configuration setting in localConfig.json #8529

Closed
6 tasks
ale-cristofori opened this issue Aug 31, 2022 · 0 comments

Comments

@ale-cristofori
Copy link
Contributor

ale-cristofori commented Aug 31, 2022

Description

This issue is created following a request from Vlaanderen, here is the support ticket

This issue is to parametrize the maxItems configuration parameter in the localConfig.json file. At the moment such configuration item is not

As pointed out by the client and also assessed by @ale-cristofori. There is actually no configuration in localConfig.json for setting the maxItems config options for the getFeatureInfo/identify tool.

This configuration can currently be only set up in the application initial state. in the appConfig.js file, that subsequently fed to the application config in the appConfig.js file. The maxItems parameter is in fact set up now here in the application, it is always undefined, and the default value is 10, as we can see it here and here

The solution would be to include the maxItems parameter in the localConfig.json file for the identify tool.
In case this is the ideal solution, I estimate the work on this to be 1 day, including tests.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

@ale-cristofori ale-cristofori added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Aug 31, 2022
@ale-cristofori ale-cristofori self-assigned this Aug 31, 2022
@ale-cristofori ale-cristofori removed their assignment Sep 1, 2022
@MV88 MV88 self-assigned this Sep 2, 2022
MV88 added a commit to MV88/MapStore2 that referenced this issue Sep 2, 2022
ale-cristofori pushed a commit that referenced this issue Sep 7, 2022
* #8529 maxItems is now used from Identify plugin

* removed test value for maxItems in cfg of Identify plugin
@ElenaGallo ElenaGallo self-assigned this Sep 15, 2022
MV88 added a commit to MV88/MapStore2 that referenced this issue Sep 16, 2022
…lutions-it#8539)

* geosolutions-it#8529 maxItems is now used from Identify plugin

* removed test value for maxItems in cfg of Identify plugin
ale-cristofori pushed a commit to ale-cristofori/MapStore2 that referenced this issue Sep 28, 2022
…lutions-it#8539)

* geosolutions-it#8529 maxItems is now used from Identify plugin

* removed test value for maxItems in cfg of Identify plugin
ale-cristofori added a commit that referenced this issue Sep 28, 2022
* #8529 maxItems is now used from Identify plugin

* removed test value for maxItems in cfg of Identify plugin

Co-authored-by: Matteo V <matteo.velludini@gmail.com>
tdipisa pushed a commit that referenced this issue Sep 29, 2022
* #8529 maxItems is now used from Identify plugin

* removed test value for maxItems in cfg of Identify plugin
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 29, 2022
@tdipisa tdipisa added this to the 2022.02.01 milestone Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants