Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem opening the Attribute Table #8570

Closed
1 task done
tdipisa opened this issue Sep 8, 2022 · 1 comment · Fixed by #8594
Closed
1 task done

Problem opening the Attribute Table #8570

tdipisa opened this issue Sep 8, 2022 · 1 comment · Fixed by #8594
Assignees
@belom88 @ElenaGallo
Labels
Accepted bug Good first issue Internal investigation Priority: High
Milestone
2022.02.01

Comments

@tdipisa
Copy link
Member

tdipisa commented Sep 8, 2022

Description

Maybe due to the modular plugin (to be confirmed) sometime when the Attribute Table is opened it will not appear immediately. This is imply in a wrong UI state.

How to reproduce

  • Open this map
  • Select one vector layer
  • Open the attribute table

Expected Result

The Attribue Table should appear immediately or the button to open the Attribute Table should be enabled only when the chunk of the plugin is loaded.

Current Result

image.png

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@tdipisa tdipisa added the bug label Sep 8, 2022
@allyoucanmap
Copy link
Contributor

@tdipisa @alexander-fedorenko this si probably due to the dynamic import done after the module import introduced here #8531.
The solution could be to add a simple callback component (an empty panel with the same size of the grid with a loading spinner) to the withSuspense HOC of the FeatureEditor plugin (to be tested).
See the withSuspense HOC that applies a null fallback component by default.

@tdipisa tdipisa assigned belom88 and unassigned tdipisa Sep 15, 2022
belom88 added a commit to belom88/MapStore2 that referenced this issue Sep 20, 2022
@belom88
geosolutions-it#8570 fallback for Attribute Table
998441d
@belom88 belom88 mentioned this issue Sep 20, 2022
Merged
12 tasks
@belom88 belom88 linked a pull request Sep 20, 2022 that will close this issue
#8570 fallback for Attribute Table #8594
Merged
12 tasks
allyoucanmap pushed a commit that referenced this issue Sep 26, 2022
@belom88
#8570 fallback for Attribute Table (#8594)
b28ad93
@allyoucanmap allyoucanmap reopened this Sep 26, 2022
@ElenaGallo ElenaGallo self-assigned this Sep 29, 2022
@tdipisa tdipisa added this to the 2022.02.01 milestone Sep 29, 2022
belom88 added a commit to belom88/MapStore2 that referenced this issue Sep 29, 2022
@belom88
geosolutions-it#8570 fallback for Attribute Table (geosolutions-it#8594)
28c7016
@belom88 belom88 mentioned this issue Sep 29, 2022
Merged
tdipisa pushed a commit that referenced this issue Sep 29, 2022
@belom88
#8570 fallback for Attribute Table (#8594) (#8635)
e56275e
@alex-fko alex-fko mentioned this issue Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@belom88 belom88

@ElenaGallo ElenaGallo

Labels
Accepted bug Good first issue Internal investigation Priority: High
Projects
None yet
Milestone
2022.02.01
Development

Successfully merging a pull request may close this issue.

#8570 fallback for Attribute Table belom88/MapStore2
5 participants
@tdipisa @alexander-fedorenko @belom88 @allyoucanmap @ElenaGallo